[liblouis-liblouisxml] Re: [liblouis] r715 committed - the last batch of files converted to utf-8.
- From: Mesar Hameed <mesar.hameed@xxxxxxxxx>
- To: Christian Egli <christian.egli@xxxxxx>
- Date: Mon, 2 Jul 2012 10:03:34 +0100
Hi Christian,
On Mon 02/07/12,10:53, Christian Egli wrote:
> Mesar Hameed <mesar.hameed@xxxxxxxxx> writes:
> > At this point all the tables are in utf-8, this does not mean that
> > they are valid tables, infact I have seen several tables that have
> > many errors, because they do not use \x for declaring their
> > characters.
>
> I applaud your efforts to get the tables into a uniform state. However
> since your commit I get tons of warnings on `make check`[1]. This means
> that we have many tables now that do not work.
Yes exactly this was my point.
> I was hoping to have a
> release before my vacation on July 15th, but we cannot release with this
> serious regression.
Why is it a regression, just because the tools did not show the errors does not
mean that they were not there, at least now we see them, and
have a chanse to fix.
> Before we change the encoding of the tables we need to either
>
> - change the tables to use the \xhhhh notation or
> - enhance compileTranslationTable.c to accept utf-8 in the opcode
> arguments
Yes the second is the prefered option.
> Only once this is done we can safely change the encoding. Please revert
> your changes.
I dont think reverting is the right thing to do.
Is there another bug that calls for the changes to be reverted other than the
encodings?
Thanks,
Mesar
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
