[haiku-development] Re: Banning Barrett
- From: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Fri, 15 Mar 2019 20:42:27 +0100
Your comment on the other hand is extremely accusatory ("What's the
reason for this half-done API?", when the reason is stated *right in
the message*: "Fix GCC8 -Werror=class-memaccess", and so your question
comes off as just an accusation),
Except that this commit didn't really fix the true issue there.
media_format is still POD
and calling memset on it is very bad.
and making a remark about having
"the same TODO" (as if we had to fix every TODO in every method or
function we change?) and then another question essentially equivalent
to the first one ("Why you add "Clear" in place of memset, then..." --
again, the reason is right in the commit message; if you hadn't heard
of -Wclass-memaccess, you could certainly have looked it up and seen
that this is one of the possible ways to mitigate it.)
Yes because I didn't fail as you to find the real issue here, memset
should not be used on POD objects.
That discussion is really draining my brain. Of course I meant non-POD
there.
Other related posts:
