[liblouis-liblouisxml] Re: back translate patch
- From: Ken Perry <kperry@xxxxxxx>
- To: "liblouis-liblouisxml@xxxxxxxxxxxxx" <liblouis-liblouisxml@xxxxxxxxxxxxx>
- Date: Mon, 30 Jun 2014 12:29:09 +0000
That might be a great procedure so the question I have for you is who is not
following this procedure? I just pulled down master clean with no changes and
made it. Then I did a make check and it fails missing tables. So who broke
the build and can it please be fixed so that I can do as requested?
Ken
-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Christian Egli
Sent: Monday, June 30, 2014 3:49 AM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] Re: back translate patch
On 06/29/2014 11:35 PM, Ken Perry wrote:
> Does any one review these patches or how should I get it in?
The ideal procedure for us as maintainers would be that you do the
following:
1. Fork the liblouis repo on github
2. In that new repo create a branch for your fix
3. Apply the fix in this new branch. Don't forget to update the NEWS
file. Make sure all the tests pass, i.e. run `make check`.
4. Open a pull request for your branch
5. We will then look at the proposed change and merge it back in master.
For an example look at the pull requests by simait
(https://github.com/liblouis/liblouis/pull/10).
Thanks
Christian
>
> Ken
>
> *From:*liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] *On Behalf Of *Ken Perry
> *Sent:* Friday, June 27, 2014 2:33 PM
> *To:* liblouis-liblouisxml@xxxxxxxxxxxxx
> *Subject:* [liblouis-liblouisxml] back translate patch
>
> This patch reverts the function change John made and it solves a lot of
> back translation issues.Can someone patch it in and try it out.I don't
> see any major problems with this.
>
> Ken
>
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
-----
Tag der offenen Tuer:
Die SBS laedt Sie herzlich ein: 28. Juni 2014 von 9 bis 16 Uhr.
Mehr Informationen erhalten Sie unter http://www.sbs.ch/offenetuer
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
