[liblouis-liblouisxml] Re: back translate patch
- From: Ken Perry <kperry@xxxxxxx>
- To: "liblouis-liblouisxml@xxxxxxxxxxxxx" <liblouis-liblouisxml@xxxxxxxxxxxxx>
- Date: Mon, 30 Jun 2014 14:39:55 +0000
OK I just removed that directory. I then pulled a fresh liblouis. I made it
and installed it. And get the same errors.
Ken
-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Bert Frees
Sent: Monday, June 30, 2014 10:33 AM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] Re: back translate patch
These tests are broken:
hyphenate_achena
hyphenate_alderen
They seem to reference the table da-dk-g2.ctb which doesn't exists in
the tables directory anymore, so I it is therefore finding an old table
in your /usr/local/share/liblouis/tables directory.
Who can fix the tests? Mesar it seems you added the tests, but maybe
someone else broke it afterwards by renaming da-dk-g2.ctb?
Bert
Ken Perry writes:
> The following typescript file is what I got after typing ./autogen.sh
> ./configure
> Make
> Sudo make install
>
> All on ubuntu 12.04
>
> Script started on Mon 30 Jun 2014 08:22:04 AM EDT
> bash: .bash_profile: No such file or directory
> kperry@stevie:~/liblouis$ make h[K[K check
> Making check in gnulib
> make[1]: Entering directory `/home/kperry/liblouis/gnulib'
> make check-recursive
> make[2]: Entering directory `/home/kperry/liblouis/gnulib'
> make[3]: Entering directory `/home/kperry/liblouis/gnulib'
> make[3]: Nothing to be done for `check-am'.
> make[3]: Leaving directory `/home/kperry/liblouis/gnulib'
> make[2]: Leaving directory `/home/kperry/liblouis/gnulib'
> make[1]: Leaving directory `/home/kperry/liblouis/gnulib'
> Making check in liblouis
> make[1]: Entering directory `/home/kperry/liblouis/liblouis'
> make[1]: Leaving directory `/home/kperry/liblouis/liblouis'
> Making check in tools
> make[1]: Entering directory `/home/kperry/liblouis/tools'
> make[1]: Nothing to be done for `check'.
> make[1]: Leaving directory `/home/kperry/liblouis/tools'
> Making check in tables
> make[1]: Entering directory `/home/kperry/liblouis/tables'
> make[1]: Nothing to be done for `check'.
> make[1]: Leaving directory `/home/kperry/liblouis/tables'
> Making check in doc
> make[1]: Entering directory `/home/kperry/liblouis/doc'
> make[1]: Nothing to be done for `check'.
> make[1]: Leaving directory `/home/kperry/liblouis/doc'
> Making check in man
> make[1]: Entering directory `/home/kperry/liblouis/man'
> make[1]: Nothing to be done for `check'.
> make[1]: Leaving directory `/home/kperry/liblouis/man'
> Making check in tests
> make[1]: Entering directory `/home/kperry/liblouis/tests'
> Making check in tables
> make[2]: Entering directory `/home/kperry/liblouis/tests/tables'
> Making check in moreTables
> make[3]: Entering directory `/home/kperry/liblouis/tests/tables/moreTables'
> make[3]: Nothing to be done for `check'.
> make[3]: Leaving directory `/home/kperry/liblouis/tests/tables/moreTables'
> Making check in resolve_table
> make[3]: Entering directory `/home/kperry/liblouis/tests/tables/resolve_table'
> Making check in dir_1
> make[4]: Entering directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_1'
> Making check in dir_1.1
> make[5]: Entering directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_1/dir_1.1'
> make[5]: Nothing to be done for `check'.
> make[5]: Leaving directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_1/dir_1.1'
> make[5]: Entering directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_1'
> make[5]: Nothing to be done for `check-am'.
> make[5]: Leaving directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_1'
> make[4]: Leaving directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_1'
> Making check in dir_2
> make[4]: Entering directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_2'
> make[4]: Nothing to be done for `check'.
> make[4]: Leaving directory
> `/home/kperry/liblouis/tests/tables/resolve_table/dir_2'
> make[4]: Entering directory `/home/kperry/liblouis/tests/tables/resolve_table'
> make[4]: Nothing to be done for `check-am'.
> make[4]: Leaving directory `/home/kperry/liblouis/tests/tables/resolve_table'
> make[3]: Leaving directory `/home/kperry/liblouis/tests/tables/resolve_table'
> make[3]: Entering directory `/home/kperry/liblouis/tests/tables'
> make[3]: Nothing to be done for `check-am'.
> make[3]: Leaving directory `/home/kperry/liblouis/tests/tables'
> make[2]: Leaving directory `/home/kperry/liblouis/tests/tables'
> Making check in doctests
> make[2]: Entering directory `/home/kperry/liblouis/tests/doctests'
> make[2]: Nothing to be done for `check'.
> make[2]: Leaving directory `/home/kperry/liblouis/tests/doctests'
> Making check in harness
> make[2]: Entering directory `/home/kperry/liblouis/tests/harness'
> make[2]: Leaving directory `/home/kperry/liblouis/tests/harness'
> Making check in harnessSources
> make[2]: Entering directory `/home/kperry/liblouis/tests/harnessSources'
> make[2]: Nothing to be done for `check'.
> make[2]: Leaving directory `/home/kperry/liblouis/tests/harnessSources'
> make[2]: Entering directory `/home/kperry/liblouis/tests'
> make pass2 pass2_inpos inpos inpos_match_replace uplow_with_unicode
> present_progressive capitalized_word capitalized_with_sentance inpos_compbrl
> lastworditalafter en_gb_g1_italics letterDefTest squash_space
> hyphenate_achena hyphenate_alderen hyphenate_straightforward hyphenate_xxx
> backtranslate_with_letsign pass1Only outpos getTable typeform pass0_typebuf
> hash_collision resolve_table logging \
> check_all_tables.pl check_endless_loop.pl
> multiple_table_path.pl
> make[3]: Entering directory `/home/kperry/liblouis/tests'
> make[3]: `pass2' is up to date.
> make[3]: `pass2_inpos' is up to date.
> make[3]: `inpos' is up to date.
> make[3]: `inpos_match_replace' is up to date.
> make[3]: `uplow_with_unicode' is up to date.
> make[3]: `present_progressive' is up to date.
> make[3]: `capitalized_word' is up to date.
> make[3]: `capitalized_with_sentance' is up to date.
> make[3]: `inpos_compbrl' is up to date.
> make[3]: `lastworditalafter' is up to date.
> make[3]: `en_gb_g1_italics' is up to date.
> make[3]: `letterDefTest' is up to date.
> make[3]: `squash_space' is up to date.
> make[3]: `hyphenate_achena' is up to date.
> make[3]: `hyphenate_alderen' is up to date.
> make[3]: `hyphenate_straightforward' is up to date.
> make[3]: `hyphenate_xxx' is up to date.
> make[3]: `backtranslate_with_letsign' is up to date.
> make[3]: `pass1Only' is up to date.
> make[3]: `outpos' is up to date.
> make[3]: `getTable' is up to date.
> make[3]: `typeform' is up to date.
> make[3]: `pass0_typebuf' is up to date.
> make[3]: `hash_collision' is up to date.
> make[3]: `resolve_table' is up to date.
> make[3]: `logging' is up to date.
> make[3]: Nothing to be done for `check_all_tables.pl'.
> make[3]: Nothing to be done for `check_endless_loop.pl'.
> make[3]: Nothing to be done for `multiple_table_path.pl'.
> make[3]: Leaving directory `/home/kperry/liblouis/tests'
> make check-TESTS
> make[3]: Entering directory `/home/kperry/liblouis/tests'
> PASS: pass2
> PASS: pass2_inpos
> PASS: inpos
> PASS: inpos_match_replace
> PASS: uplow_with_unicode
> string='greetings ' cursor=10 (' ') expected=8 recieved=7 (' ')
> XFAIL: present_progressive
> PASS: capitalized_word
> PASS: capitalized_with_sentance
> PASS: inpos_compbrl
> Input: 'Er sagte es funktioniere nicht immer wie erwartet.'
> Expected: '_ER SAGTE ES __FUNKTION0RE NI4T', IMMER W0 ERWARTET.'
> Received: '_ER SAGTE ES __FUNKTION0RE _NI4T IMMER W0 ERWARTET.'
> Diff: Expected 'N' but recieved '_' in index 27
> XFAIL: lastworditalafter
> Input: 'This is a Test in Italic.'
> Expected: '..,this is a ,test in ,italic4.''
> Received: ',this is a ,test in ,italic4.''
> Diff: Expected '.' but recieved ',' in index 0
> Input: 'This is a Test'
> Expected: ',this .is .a ,test'
> Received: ',this is a.' ,test'
> Diff: Expected '.' but recieved 'i' in index 6
> Input: 'time and spirit'
> Expected: '."t .& ._s'
> Received: 'time and spirit.''
> Diff: Expected '.' but recieved 't' in index 0
> XFAIL: en_gb_g1_italics
> PASS: letterDefTest
> Input: ' '
> Expected: ' '
> Received: ' '
> Diff: Expected nothing but recieved ' ' in index 1
> Input: ' '
> Expected: ' '
> Received: ' '
> Diff: Expected ' ' but recieved ' ' in index 0
> Input: '
> '
> Expected: ' '
> Received: ' '
> Diff: Expected nothing but recieved ' ' in index 1
> Input: '
> '
> Expected: ' '
> Received: ' '
> Diff: Expected nothing but recieved ' ' in index 1
> Input: ' '
> Expected: ' '
> Received: ' '
> Diff: Expected ' ' but recieved ' ' in index 0
> XFAIL: squash_space
> XPASS: hyphenate_achena
> XPASS: hyphenate_alderen
> PASS: hyphenate_straightforward
> PASS: hyphenate_xxx
> PASS: backtranslate_with_letsign
> PASS: pass1Only
> PASS: outpos
> ../tests/tables/bad.ctb:1: error: opcode 'bad' not defined.
> ../tests/tables/bad.ctb:2: error: opcode 'bad' not defined.
> 2 errors found.
> bad.ctb could not be found
> PASS: getTable
> PASS: typeform
> PASS: pass0_typebuf
> Input: 'aaaaa'
> Expected: 'a'
> Received: ' '
> Diff: Expected 'a' but recieved ' ' in index 0
> Input: 'aazzz'
> Expected: 'a'
> Received: ' '
> Diff: Expected 'a' but recieved ' ' in index 0
> XFAIL: hash_collision
> Cannot resolve table 'table_1'
> 1 errors found.
> table_1 could not be found
> Cannot resolve table 'table_1.1.1'
> 1 errors found.
> tables/resolve_table/table_1,table_1.1.1 could not be found
> Cannot resolve table 'table_1.2'
> 1 errors found.
> table_1,tables/resolve_table/dir_1/table_1.1,table_1.2 could not be found
> Cannot resolve table 'table_1'
> 1 errors found.
> tables/resolve_table/table_5 could not be found
> PASS: resolve_table
> PASS: logging
> PASS: check_all_tables.pl
> PASS: check_endless_loop.pl
> PASS: multiple_table_path.pl
> ==============================================================
> 2 of 29 tests did not behave as expected (2 unexpected passes)
> Please report to liblouis-liblouisxml@xxxxxxxxxxxxx
> ==============================================================
> make[3]: *** [check-TESTS] Error 1
> make[3]: Leaving directory `/home/kperry/liblouis/tests'
> make[2]: *** [check-am] Error 2
> make[2]: Leaving directory `/home/kperry/liblouis/tests'
> make[1]: *** [check-recursive] Error 1
> make[1]: Leaving directory `/home/kperry/liblouis/tests'
> make: *** [check-recursive] Error 1
> kperry@stevie:~/liblouis$
> kperry@stevie:~/liblouis$ exot
> exot: command not found
> kperry@stevie:~/liblouis$ exit
> exit
>
> Script done on Mon 30 Jun 2014 08:22:23 AM EDT
>
> From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Simon Aittamaa
> Sent: Monday, June 30, 2014 9:47 AM
> To: liblouis-liblouisxml@xxxxxxxxxxxxx
> Subject: [liblouis-liblouisxml] Re: back translate patch
>
> Hi Ken,
>
> Current master (sha1: 15e785fbdf7a69c7b6ab0e4fecaf1ef206853cda), builds
> cleanly for me (on Ubuntu 12.04.4 LTS).
> make check:
> ======================================================
> All 29 tests behaved as expected (7 expected failures)
> ======================================================
> Perhaps you could provide some more info, e.g. which files are missing, or a
> complete log, i.e. make check &> make-check.log.
> Best,
> Simon
>
> On 30 June 2014 14:29, Ken Perry <kperry@xxxxxxx<mailto:kperry@xxxxxxx>>
> wrote:
> That might be a great procedure so the question I have for you is who is not
> following this procedure? I just pulled down master clean with no changes
> and made it. Then I did a make check and it fails missing tables. So who
> broke the build and can it please be fixed so that I can do as requested?
>
> Ken
>
> -----Original Message-----
> From:
> liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
>
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>]
> On Behalf Of Christian Egli
> Sent: Monday, June 30, 2014 3:49 AM
> To:
> liblouis-liblouisxml@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml@xxxxxxxxxxxxx>
> Subject: [liblouis-liblouisxml] Re: back translate patch
>
> On 06/29/2014 11:35 PM, Ken Perry wrote:
>> Does any one review these patches or how should I get it in?
>
> The ideal procedure for us as maintainers would be that you do the
> following:
>
> 1. Fork the liblouis repo on github
> 2. In that new repo create a branch for your fix
> 3. Apply the fix in this new branch. Don't forget to update the NEWS
> file. Make sure all the tests pass, i.e. run `make check`.
> 4. Open a pull request for your branch
> 5. We will then look at the proposed change and merge it back in master.
>
> For an example look at the pull requests by simait
> (https://github.com/liblouis/liblouis/pull/10).
>
> Thanks
> Christian
>>
>> Ken
>>
>> *From:*liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>
>> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx>]
>> *On Behalf Of *Ken Perry
>> *Sent:* Friday, June 27, 2014 2:33 PM
>> *To:*
>> liblouis-liblouisxml@xxxxxxxxxxxxx<mailto:liblouis-liblouisxml@xxxxxxxxxxxxx>
>> *Subject:* [liblouis-liblouisxml] back translate patch
>>
>> This patch reverts the function change John made and it solves a lot of
>> back translation issues.Can someone patch it in and try it out.I don't
>> see any major problems with this.
>>
>> Ken
>>
>
>
> --
> Christian Egli
> Swiss Library for the Blind, Visually Impaired and Print Disabled
> Grubenstrasse 12, CH-8045 Zürich, Switzerland
>
>
> -----
> Tag der offenen Tuer:
> Die SBS laedt Sie herzlich ein: 28. Juni 2014 von 9 bis 16 Uhr.
> Mehr Informationen erhalten Sie unter http://www.sbs.ch/offenetuer
> For a description of the software, to download it and links to
> project pages go to http://www.abilitiessoft.com
> For a description of the software, to download it and links to
> project pages go to http://www.abilitiessoft.com
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
