[liblouis-liblouisxml] Re: back translate patch

  • From: Christian Egli <christian.egli@xxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Mon, 30 Jun 2014 17:15:40 +0200

On 06/30/2014 04:32 PM, Bert Frees wrote:
These tests are broken:

hyphenate_achena
hyphenate_alderen

They seem to reference the table da-dk-g2.ctb which doesn't exists in
the tables directory anymore

I just pushed a fix for these tests. They now refer to the table da-dk-g26.ctb and since they actually pass now they are no longer marked as expected failure in the Makefile.

Hope that resolves things.

Now, back to the original issue which was about backtranslation and creating pull requests.

Who can fix the tests? Mesar it seems you added the tests, but maybe
someone else broke it afterwards by renaming da-dk-g2.ctb?

Well there was the great danish table improvement by Mesar and Bue, where these test simply were forgotten. Unfortunately because the old tables were still around on most peoples systems nobody seems to have noticed. We should probably look at the continuous integration server travis now that we are on github.


Thanks
Christian

--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland

For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com

Other related posts: