[liblouis-liblouisxml] Re: back translate patch
- From: "Joseph Lee" <joseph.lee22590@xxxxxxxxx>
- To: <liblouis-liblouisxml@xxxxxxxxxxxxx>
- Date: Mon, 30 Jun 2014 11:26:03 -0700
Hi,
If Mesar agrees, we could invite you to our Bitbucket repo, create a branch so
Mesar can integrate it into the master repo at Github.
Cheers,
Joseph
-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Ken Perry
Sent: Monday, June 30, 2014 11:01 AM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] Re: back translate patch
Looking into this farther do I have to have a git hub account to submit
patches? If yes is there any reason the maintainers can not receive patches so
I don't have to have yet another account?
Ken
-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Ken Perry
Sent: Monday, June 30, 2014 1:43 PM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] Re: back translate patch
OK I have my commit. We have always used patches to commit stuff so this is
the first time I have had to do request-pull. Can I do everything from the
command line? I have read many docs already on how request-pullworks but I am
trying to find the easiest way to do this. Do I have to go to the web site to
fork a change or can I just push a branch up to origin? If someone has an easy
step by step way to do git request -pull that would be of great assistance.
Currently I have done:
Git clone ..
Git checkout -b myBranch
Made changes
Git add files
Git commit -m "full comment"
So what I need to know is what is the best way to create the remote and push to
it.
Ken
-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Christian Egli
Sent: Monday, June 30, 2014 11:16 AM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] Re: back translate patch
On 06/30/2014 04:32 PM, Bert Frees wrote:
> These tests are broken:
>
> hyphenate_achena
> hyphenate_alderen
>
> They seem to reference the table da-dk-g2.ctb which doesn't exists in
> the tables directory anymore
I just pushed a fix for these tests. They now refer to the table
da-dk-g26.ctb and since they actually pass now they are no longer marked
as expected failure in the Makefile.
Hope that resolves things.
Now, back to the original issue which was about backtranslation and
creating pull requests.
> Who can fix the tests? Mesar it seems you added the tests, but maybe
> someone else broke it afterwards by renaming da-dk-g2.ctb?
Well there was the great danish table improvement by Mesar and Bue,
where these test simply were forgotten. Unfortunately because the old
tables were still around on most peoples systems nobody seems to have
noticed. We should probably look at the continuous integration server
travis now that we are on github.
Thanks
Christian
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
h��^���ب����(~���hv�'����֧vX���h��#y�ij
���h��i��0���+bz�(~�(
��u� �*m���~�^������h�yhiحjwe�y,��k�7����z�(��m����
n)b�'����
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
Other related posts:
