[liblouis-liblouisxml] Re: back translate patch
- From: Ken Perry <kperry@xxxxxxx>
- To: "liblouis-liblouisxml@xxxxxxxxxxxxx" <liblouis-liblouisxml@xxxxxxxxxxxxx>
- Date: Tue, 1 Jul 2014 11:07:54 +0000
Ok look I was having blind guy having to sign up for yet another crappy web
service draw back. Let me just say Wow this git hub stuff works really well
and I am going to use it for some stuff I am working on. Very nice.
If all went well I have a pull-request in. If I don't please let me know so I
can figure out what I did wrong.
Thanks,
ken
-----Original Message-----
From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
[mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Christian Egli
Sent: Tuesday, July 1, 2014 3:08 AM
To: liblouis-liblouisxml@xxxxxxxxxxxxx
Subject: [liblouis-liblouisxml] Re: back translate patch
Hi all
Ken sorry to bring all this trouble to you. You don't have to do
anything. You can just send the patch to this list, like in the (g)olden
days :-). However if you do create a form on github, push your changes
there it will be much more likely that we will integrate it. I can only
speak for myself, but github pull requests have made my live as a
maintainer drastically simpler. It's much easier to integrate patches
that way. We can discuss pull requests, improve them, get feedback from
the originator, etc. I think it helps improve the quality of the software.
And please lets focus on one repo and not create more branches on
bitbucket. That is a sure recipe to get the patch forgotten. I will not
look there.
So to answer your question, yes afaik you do need an account on github
and I don't know if you can create a from from the command line. There
are command line tools for github out there for example
https://hub.github.com.
Thanks
Christian
On 06/30/2014 08:26 PM, Joseph Lee wrote:
> Hi,
> If Mesar agrees, we could invite you to our Bitbucket repo, create a branch
> so Mesar can integrate it into the master repo at Github.
> Cheers,
> Joseph
>
> -----Original Message-----
> From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Ken Perry
> Sent: Monday, June 30, 2014 11:01 AM
> To: liblouis-liblouisxml@xxxxxxxxxxxxx
> Subject: [liblouis-liblouisxml] Re: back translate patch
>
> Looking into this farther do I have to have a git hub account to submit
> patches? If yes is there any reason the maintainers can not receive patches
> so I don't have to have yet another account?
>
> Ken
>
> -----Original Message-----
> From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Ken Perry
> Sent: Monday, June 30, 2014 1:43 PM
> To: liblouis-liblouisxml@xxxxxxxxxxxxx
> Subject: [liblouis-liblouisxml] Re: back translate patch
>
> OK I have my commit. We have always used patches to commit stuff so this is
> the first time I have had to do request-pull. Can I do everything from the
> command line? I have read many docs already on how request-pullworks but I
> am trying to find the easiest way to do this. Do I have to go to the web
> site to fork a change or can I just push a branch up to origin? If someone
> has an easy step by step way to do git request -pull that would be of great
> assistance.
>
> Currently I have done:
>
> Git clone ..
> Git checkout -b myBranch
> Made changes
> Git add files
> Git commit -m "full comment"
>
>
> So what I need to know is what is the best way to create the remote and push
> to it.
> Ken
>
> -----Original Message-----
> From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of Christian Egli
> Sent: Monday, June 30, 2014 11:16 AM
> To: liblouis-liblouisxml@xxxxxxxxxxxxx
> Subject: [liblouis-liblouisxml] Re: back translate patch
>
> On 06/30/2014 04:32 PM, Bert Frees wrote:
>> These tests are broken:
>>
>> hyphenate_achena
>> hyphenate_alderen
>>
>> They seem to reference the table da-dk-g2.ctb which doesn't exists in
>> the tables directory anymore
>
> I just pushed a fix for these tests. They now refer to the table
> da-dk-g26.ctb and since they actually pass now they are no longer marked
> as expected failure in the Makefile.
>
> Hope that resolves things.
>
> Now, back to the original issue which was about backtranslation and
> creating pull requests.
>
>> Who can fix the tests? Mesar it seems you added the tests, but maybe
>> someone else broke it afterwards by renaming da-dk-g2.ctb?
>
> Well there was the great danish table improvement by Mesar and Bue,
> where these test simply were forgotten. Unfortunately because the old
> tables were still around on most peoples systems nobody seems to have
> noticed. We should probably look at the continuous integration server
> travis now that we are on github.
>
>
> Thanks
> Christian
>
--
Christian Egli
Swiss Library for the Blind, Visually Impaired and Print Disabled
Grubenstrasse 12, CH-8045 Zürich, Switzerland
For a description of the software, to download it and links to
project pages go to http://www.abilitiessoft.com
��u� �*m���~�^������h�yhiحjwe�y,��k�7����z�(��m���� n)b�'����r�
Other related posts:
