[procps] Re: cgroup support for new top
- From: "Dr. Werner Fink" <werner@xxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Thu, 14 Apr 2011 14:32:55 +0200
On Thu, Apr 14, 2011 at 01:01:14PM +0200, Werner Fink wrote:
> > What you claim is fixed was never broken in this newtop.
>
> Hmmm ... I'm missing oom support as well as support for
> hotplugged cpus (very common on s390/ppc64 zSeries) and
> better support for batch job (that is no SIGHUP handler
> if the batch option is used).
I've to correct my self ... the SIGHUP handler is not
used in batch mode anymore. And Craig has added an
optional ZAP_SUSEONLY define for oom support, thanks a lot!
> > This newtop supports hotplugged cpus, but your library's
> > sysinfo.c does not. Why you transformed smp_num_cpus into
> > a function only to return an invariant value is a mystery.
>
> This patch based on a change from SGI of a bug report, the
> request was to minimize read access to /proc/stat which will
> be caused e.g. by a call to sysconf(_SC_NPROCESSORS_ONLN)
> the former solution with a constructor had caused that /proc/stat
> was always scanned for every program using libproc.
> > This newtop supports hundreds of cpus and terabytes of memory.
> > And it does so without a useless left shift as in your top.
> >
> > And yes, this vastly more capable newtop will not respect a
> > old .toprc file. It's a small price to pay for the improvements.
> > Still, by enabling a #define, one can alert the user of that
> > rejection rather than silently defaulting. Your current top
> > doesn't even offer that option.
>
> The problem I've with this is that in my experience this will
> lead to a lot of regressions, that is that the number of my
> bugzilla entries will increase a lot.
I see that the format of Id:f is now a binary one ...
Werner
--
"Having a smoking section in a restaurant is like having
a peeing section in a swimming pool." -- Edward Burr
Other related posts:
