[procps] Re: cgroup support for new top

  • From: Jim Warner <james.warner@xxxxxxxxxxx>
  • To: procps@xxxxxxxxxxxxx
  • Date: Fri, 8 Apr 2011 10:44:03 -0500

On Apr 7, 2011, at 4:46 AM, Jan Görig wrote:
...
> Jim, could you review this patch, please? Thanks.
> 

Hi Jan,

I never imagined there would be need for a 2nd variable width column.  Your 
approach in sharing maxcmdln made sense but there was a problem with the 
altered endpflg scrolling logic.  Also, I have this character flaw wherein I 
hate to proliferate loops.

In addressing those issues I decided to go whole hog and update some 
identifiers and comments.  The attached patch is offered as an alternative 
against a clean newtop.

When the libproc cgroup interface has been optimized and finalized, I'd be 
happy to clean up top.

By the way, Craig is sitting on some patches to newtop and I've got one more 
set in the pipeline. I'm trying to build a fire under our Sydney associate.

Regards,
Jim




Other related posts: