OK< I will change it so that setting to NULL just changes it back to default and that a separate function call is needed to turn logging off completely.
Michael Whapples On 28/04/2014 15:16, Keith Creasy wrote:
I have to agree with John here. We really don't want people turning logging off. We just need a way to optionally pipe the log messages through a callback. If we do allow them to disable logging it has to be something very explicit that they must do. -----Original Message----- From: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] On Behalf Of John J. Boyer Sent: Monday, April 28, 2014 10:10 AM To: liblouis-liblouisxml@xxxxxxxxxxxxx Subject: [liblouis-liblouisxml] Re: New Releases I find the idea that if no callback is specified then lou_logPrint is used as at present intuitive. I do like the idea of having a function call to turn off logging. It shouldn't be made easy. In my original message I intended to suggest that liblouis and liblouisutdml should be released at the same time, once everything is ready in both libraries. JohnOn Mon, Apr 28, 2014 at 09:59:10AM +0100, Michael Whapples wrote:There was one other option I did suggest in the past: By default a default callback is used (may be lou_logPrint), if one sets the callback to lou_logPrint then the default is used, if one wishes to turn off logging then they call a function to toggle logging. Which feels more intuitive? PS. I forgot to say, I feel it would be wise to hold off on the liblouisutdml release. It relies on stuff currently in liblouis SVN and so liblouisutdml should not be released until a release of liblouis with that required stuff is made. Michael Whapples On 28/04/2014 09:55, John J. Boyer wrote:The latter option is what I would favor. I suppose the user should be able to turn off logging, but I think that s/he should be told that it would be unwise in most circumstances. John On Mon, Apr 28, 2014 at 09:41:24AM +0100, Michael Whapples wrote:What to do if no callback is given is a good question. One might suggest that the logging stuff does not get called (IE. its a way to turn off logging). Another option is to have a default callback, which could be lou_logPrint. I think I am heading for the latter, but to enable turning off the logging one can set the logging callback to NULL. Does that sound reasonable? Michael Whapples On 28/04/2014 09:37, John J. Boyer wrote:I had proposed a releasee of liblouisutdml on May 1. However, I think the work on logging should be completed and then liblouis and liblouisutdml should be released together. I will be happy to have Christian do the releases and put them on the liblouis website. On logging, I understood the advantages when Keith explained that it was much better to use a callback than a logging file. The file gave me trouble also. I'm wondering what happens if no callbacck is given. Shouldn't the behavior be the same as it is now? JohnFor a description of the software, to download it and links to project pages go to http://www.abilitiessoft.comFor a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com-- John J. Boyer; President, Chief Software Developer Abilitiessoft, Inc. http://www.abilitiessoft.com Madison, Wisconsin USA Developing software for people with disabilities For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com
For a description of the software, to download it and links to project pages go to http://www.abilitiessoft.com
