On 16/12/2008 12:22 AM, Christian Egli wrote:
There shouldn't be any code differences from 1.3.9. However, the autotool stuff is different, the ChangeLog contains more detail and there are some unit tests.liblouis will be a little more tricky. I guess we could overwrite everything in the subversion repository with your source code, however it would probably be nice to include improvements that have been done in the subversion repository (if there are any).
I was going to sync the autotool stuff in svn with John's changes, but Eitan said that he also had an autotooled liblouisxml which worked with this, so I held off for a while. Eitan, have you had a chance ot check this out? It'd be good to get this autotool disgrepancy sorted out once and for all.So I guess this would have to be merged manually which is a bit of work.
Regarding the unit tests, given that unit testing in C is a bit painful, Eitan and I were thinking of doing the unit tests in Python. However, this would mean that test writers would need to know Python. On the other hand, it is far quicker and easier to write tests. Any thoughts on this?
Concerning the Python bindings: John, they're in another svn branch, which is why you can't see them. They should be merged back into the main distribution once they're complete.
There are a few other things that prevent a straight import of new stuff:* The liblouisxml tarball is user-ready; i.e. it contains ./configure, etc., which should be generated when required by ./autogen.sh. These files should be removed and an appropriate autogen.sh created. Any other files which can be automatically generated should likewise be removed. * There are major disgrepancies in the line ending style of the braille tables included with liblouis. Some are Unix line endings, some are DOS line endings, others are a combination of the two. A policy needs to be made on this and all files should be converted appropriately. I'm guessing that Unix line endings are the preference, given that the rest of the code adhears to this.
-- James Teh Email/MSN Messenger/Jabber: jamie@xxxxxxxxxxx Web site: http://www.jantrid.net/ For a description of the software and to download it go to http://www.jjb-software.com