[procps] Re: procps changes
- From: Jim Warner <james.warner@xxxxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Wed, 28 Sep 2011 14:44:00 -0500
On Sep 28, 2011, at 2:28 PM, Sami Kerola wrote:
> Perhaps the autogen.sh message should be removed. After all it assumes one
> does not have various utilities, while the real problem could be caused for
> instance IO error that is visible in the program error.
>
> But I really don't think we should spend much more time to hone this script.
> Most of the world will build from dist package, which does not require
> autogen.sh run. Thous who pull git version are usually technical enough to
> appreciate verbose errors when things go wrong.
If you were to eliminate one or the other I would vote to keep your messages
and dispense with the bash messages.
>> Also, perhaps that script and configure should fail if they're not run from
>> the user's current directory. Otherwise the Makefiles and .deps
>> directories get misplaced after configure thus making a build impossible.
>
> Did you try out of tree build? Mine was successful.
I did and and was just about to email a revision. It boils down to some
unnecessary code in autogen.sh. The example diff below will illustrate what I
mean. See if you don't agree.
> -rwxr-xr-x kerolasa kerolasa top
> Could the 'wrong permissions' be a cause of your umask?
I'm out of my league here. On a pretty vanilla ubuntu system if I sudo mkdir I
get 750 but when I sudo su and then mkdir I get 755. Perhaps you know why.
Regards,
Jim
diff --git a/autogen.sh b/autogen.sh
index e9b2868..9bb21bb 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -6,15 +6,9 @@
SRCDIR=$(dirname ${0})
test -z "${SRCDIR}" && SRCDIR=.
-THEDIR=$(pwd)
cd ${SRCDIR}
DIE=0
-test -f top.c || {
- echo "You must run this script in the top-level procps-ng directory"
- DIE=1
-}
-
Other related posts:
