[procps] Re: procps changes
- From: Sami Kerola <kerolasa@xxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Fri, 23 Sep 2011 22:55:06 +0200
On Fri, Sep 23, 2011 at 08:18, Craig Small <csmall-procps@xxxxxxxxxx> wrote:
> On Fri, Sep 23, 2011 at 07:00:30AM +0200, Sami Kerola wrote:
>> I think you are referring to change bellow. Again I tried to keep in paths
>> where they where before autotools where reintroduced. One could
>
> It is best to keep the paths to the standard autotools locations and let
> distributions put them where they want using the standard ways they do it
> now. I think that's what you have done.
>
> It's probably 'wierd' for Jim because he hasn't had to suffer trying to fix
> that as a distributor.
I read that as as a request to throw away the change which did
usrbin_execdir='${exec_prefix}/usr/bin' -> '${exec_prefix}/bin'
And now that is indeed gone.
> My preference is to keep the auto* as standard and plain vanilla as it can
> possibly be and only fudge things if or when we really need to. That is how
> psmisc is done, for example.
It seems to boil down to question usrbin_exec_PROGRAMS really needed? If not
the patch bellow shows how to get rid of that, and it's then up to packagers
to relocate stuff where ever they want it to go.
-- snip
diff --git a/Makefile.am b/Makefile.am
index 890f71b..9adcd9a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -11,8 +11,6 @@ sbin_PROGRAMS = \
bin_PROGRAMS = \
kill
-
-usrbin_exec_PROGRAMS = \
free \
pgrep \
pkill \
@@ -42,7 +40,7 @@ dist_man_MANS = \
w.1
if HAVE_NCURSES
-usrbin_exec_PROGRAMS += \
+bin_PROGRAMS += \
slabtop \
top \
watch
diff --git a/configure.ac b/configure.ac
index acbb44b..3ab0296 100644
--- a/configure.ac
+++ b/configure.ac
@@ -95,9 +95,6 @@ AC_CHECK_FUNCS([\
wcwidth
])
-usrbin_execdir='${exec_prefix}/usr/bin'
-AC_SUBST([usrbin_execdir])
-
dnl UTIL_CHECK_LIB(LIBRARY, FUNCTION, [VARSUFFIX = $1]))
dnl The VARSUFFIX is optional and overrides the default behaviour. For example:
dnl UTIL_CHECK_LIB(yyy, func, xxx) generates have_xxx and HAVE_LIBXXX
-- snip
If someone wants that I'm sure he will submit real patch to upstream.
On Fri, Sep 23, 2011 at 14:12, Jim Warner <james.warner@xxxxxxxxxxx> wrote:
> Below is a patch to your latest ng branch re-renaming libprocng-3.3.0 to
> libproc-ng-3.3.0 as suggested by Craig and Jan. I actually tried for that
> name initially but couldn't decipher the autoconf variable naming
> conventions. So I resorted to trial and error this time.
I changed the `rename libproc to libprog-ng' commit. Forced update to my
repository is done.
> Please don't forget to check your autotools conventions against:
> /usr/share/doc/autotools-dev/README.Debian.gz
I think the ./autogen.sh makes procps-ng to comply with README.Debian.gz
Basic summary's first point. These two builds should prove that the autotools
mostly work.
./autogen.sh && ./configure && make dist &&
tar xzf procps-ng-3.3.0.tar.gz && cd procps-ng-3.3.0 &&
./configure --prefix=/tmp/procps-3.3.0-distbuild && make &&
make install
mkdir /tmp/foobar
cd /tmp/foobar
/path/to/procps-ng/autogen.sh
/path/to/procps-ng/configure --prefix=/tmp/procps-3.3.0-outoftree && make &&
make install
--
Sami Kerola
http://www.iki.fi/kerolasa/
Other related posts:
