[procps] Re: procps changes

  • From: Sami Kerola <kerolasa@xxxxxx>
  • To: procps@xxxxxxxxxxxxx
  • Date: Wed, 28 Sep 2011 21:28:13 +0200

On Wed, Sep 28, 2011 at 19:03, Jim Warner <james.warner@xxxxxxxxxxx> wrote:

Hi Jim et.al.

> Yes, better on consistency.  But as a "user", the autogen script "feels"
> incomplete/wrong when a get a bash error message followed by your error
> message.  They both really say the same thing and thus are redundant.

Perhaps the autogen.sh message should be removed.  After all it assumes one
does not have various utilities, while the real problem could be caused for
instance IO error that is visible in the program error.

But I really don't think we should spend much more time to hone this script.
Most of the world will build from dist package, which does not require
autogen.sh run.  Thous who pull git version are usually technical enough to
appreciate verbose errors when things go wrong.

> Also, perhaps that script and configure should fail if they're not run from
> the user's current directory.  Otherwise the Makefiles and .deps
> directories get misplaced after configure thus making a build impossible.

Did you try out of tree build?  Mine was successful.

cd procps-ng
mkdir ../foo
cd ../foo
../procps-ng/configure --prefix=/tmp/foobuild
make install

I cannot think any reason why tree build should not work.  It is one of thous
things that you get for free when autotools are set up correctly.

> I noticed too that the install directories still carry the 750 permissions.
> Do you feel that they should be 755?

$ namei -l /tmp/foobuild/usr/bin/top
f: /tmp/foobuild/usr/bin/top
drwxr-xr-x root     root     /
drwxrwxrwt root     root     tmp
drwxr-xr-x kerolasa kerolasa foobuild
drwxr-xr-x kerolasa kerolasa usr
drwxr-xr-x kerolasa kerolasa bin
-rwxr-xr-x kerolasa kerolasa top

Could the 'wrong permissions' be a cause of your umask?

$ umask

> Lastly, would you also consider the small patch below?  Is just properly
> names a program and eliminates a 'cd' since that wouldn't survive script
> end.

You are right, the cd is pointles. Calling libtoolize as libtoolize sounds
right. I squashed both to earlier commit & pushed with force.

   Sami Kerola

Other related posts: