[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 29 Nov 2015 17:18:34 +0100


Thank you!

I think if you wanted to review anything it would be all the color changes
for all the apps themselves. You can make it easy on yourself and use the
patch file and search for 4f24a87b650df80e6e85f70135d93578cc7054f7 or the
"Chart colors and some font awareness" commit.


Besides the technical things that others pointed out, which is a subject
where I can't say nothing, other code looks like OK for me, except some
minor problems. I've created a gist where I'm listing what I've seen :

https://gist.github.com/Barrett17/4d5543b35fa3056a8429

I've tried to list recurrent violations, possibly at the first occurrence
in the patch. But note that for every line in my list, you should check the
whole patch. The final aim is to get you enough used to the conventions so
that we will not have to worry about it in future. I'm afraid that big^2
patches like this aren't the best way to get in touch. It was better if we
could review a few little patches from you, and then at some point if you
want it, you could ask for commit access.

Note also that for most fixes (especially when you don't need a newline)
you can do it directly in the patch by editing those specific lines (i.e.
add a tab or remove it, fix a typo). This makes the process more faster and
less annoying.

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 11-2015