I have made all requested changes, and then some, including rewording
various commits with typos.
A full history patch and a diff can be found here:
http://files.looncraz.net/svc/
Changes of note:
DelayedMessage.h exposed only class DelayedMessage.
DelayedMessage.cpp contains the entire implementation (Attachment,
DelayedMessage, DelayedMessageData, DelayedMessageSender, ScheduledMessage).
There are no other files for DelayedMessage.
Furthermore, I simplified the constructor immensely, and merging logic
requires an additional step. I also implemented a callback on failure
mechanism and found numerous other style issues that were not mentioned.
Lastly, I stopped the app_server from sending B_FONT_UPDATED until such
a time as application can actually gain access to the updated font
information (which I have working in another branch).
I have run every Haiku style checker I can and examined every false
positive, but I'm sure I missed something somewhere.
--The loon