[haiku-development] Re: Final Set*UIColor Patch, Version 3e
- From: "Adrien Destugues" <pulkomandy@xxxxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Sun, 22 Nov 2015 07:24:43 +0000
My final patch, located here: http://files.looncraz.net/svc , includes style
corrections even for
code that I did not create. I have tried to be as patient as I can be, and
have addressed every
concern presented to me in a timely and, I hope, courteous manner. I have
done this for almost
exactly two months now, and have effectively rewritten this patch twice (much
of the fault of that
is certainly my own).
Thanks!
Finally, I have received numerous e-mails from those who believe I am not
being treated in a manner
consistent with previous submitters. I can't say that I disagree, entirely,
but the issues raised
were genuine issues, however often laughingly minor.
Hello people,
If you want the Haiku project to improve, it would be useful to make the people
reviewing the patches aware of the problem. I did not intentionally did any
thing differently with this patch. If you think I did, I would much appreciate
getting a warning when I cross the line, so I can make sure it doesn't happen
again. If you think it is not a good idea to send this publicly to the mailing
list, you can send it in private.
This patch was submitted to the mailing list (usually they go through the bug
tracker) and got quite fast review, even if it is not applied yet. We have some
patches lingering since years (!) on Trac. An example I can think of is Stack
And Tile, which lived in a branch for a long time before we finally managed to
merge it. Our patch review process certainly isn't perfect and is much too slow.
Also, I think you made some improvements to checkstyle in the process? If
that's the case, sharing your version of the script would be appreciated. It
will be less wasted time for the next people contributing.
My only feelings on the matter are that the
prioritization is backwards. I would not expect Haiku to accept a patch which
does not follow its
style guidelines, by no means. However, I would have anticipated that the
functional aspects of the
patch would be the first item on the agenda, rather than barely being
mentioned.
Maybe there is not much to say on the functional aspects. I think these were
already discussed while you were implementing the whole thing, and I have not
much to add. I may already have some other uses for delayed BMessages in
another project I'm working on, so I'm definitely looking forward to that.
--
Adrien.
Other related posts:
- » [haiku-development] Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e - Adrien Destugues
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Axel Dörfler
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Stephan Aßmus
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Dario Casalinuovo
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Adrien Destugues
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Adrien Destugues
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Jérôme Duval
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Adrien Destugues
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Jérôme Duval
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- scottmc
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- scottmc
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Adrien Destugues
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Axel Dörfler
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Jérôme Duval
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Adrien Destugues
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Stephan Aßmus
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Stephan Aßmus
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Stephan Aßmus
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Stephan Aßmus
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Alexander von Gluck IV
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Jérôme Duval
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- John Scipione
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Axel Dörfler
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Brian Hague
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- looncraz
- » [haiku-development] Re: Final Set*UIColor Patch, Version 3e- Dario Casalinuovo