[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: Dario Casalinuovo <b.vitruvio@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 22 Nov 2015 20:02:37 +0100

Hi,
Thanks for your work.


There comes a time when you have to call good enough... good enough. I
cannot afford to keep putting effort into Haiku without seeing any benefit
from doing so, so I do not intend to continue any Haiku related development
until such a time as I can see some return on my work.


I think the only thing which still is a barrier to review your work
properly is splitting it into more little patches. Don't take it as
something to steal your time, think of it as an increased possibility that
your work will get applied soon. Since we get commits on a day basis, it's
just an advantage if people interested to review is put in condition to be
focused on most important parts and to understand the chronology of
changes. For example if you split style fixes in a separate patch it's more
easy to understand what functional changes you really done other than
making more easy to dive into the code.

My suggestion, without any pretense, is that you take a moment to look that
splitting isn't a waste of time and in the end will make the everyone work
more easy. You can use git add -p, or manually edit the .diff into little
parts then apply/commit.

--
Best Regards,
Dario

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 11-2015