[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: Adrien Destugues <pulkomandy@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 22 Nov 2015 20:26:15 +0100

On Sun, Nov 22, 2015 at 01:16:00PM -0600, looncraz wrote:

On 11/22/2015 13:02, Dario Casalinuovo wrote:
Hi,
Thanks for your work.

Howdy,

Thank you!

I think the only thing which still is a barrier to review your work
properly is splitting it into more little patches.

Unfortunately, there is very little in this patch that is optional, and
splitting that up is not really readily achievable because I rewrote the
history on request.

I split up the commits by each affected application, and each area when I
rewrote the history. And, now, there are some additional commits to cleanup
some style issues and to change DelayedMessage's construction and hide its
implementation entirely.

I could certainly rewrite history yet again, I can copy-and-paste the old
commit messages, but the end result would be to just eliminate a few of the
commits at the end of the history.

As far as I can see, the current split is good, the commits can be
applied one at a time and tested individually, and there's no need to
cut it down further.

--
Adrien.

Other related posts:

  1. Home
  2. haiku-development
  3. Archive
  4. 11-2015