[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 22 Nov 2015 13:16:00 -0600

On 11/22/2015 13:02, Dario Casalinuovo wrote:

Hi,
Thanks for your work.

Howdy,

Thank you!

I think the only thing which still is a barrier to review your work properly is splitting it into more little patches.

Unfortunately, there is very little in this patch that is optional, and splitting that up is not really readily achievable because I rewrote the history on request.

I split up the commits by each affected application, and each area when I rewrote the history. And, now, there are some additional commits to cleanup some style issues and to change DelayedMessage's construction and hide its implementation entirely.

I could certainly rewrite history yet again, I can copy-and-paste the old commit messages, but the end result would be to just eliminate a few of the commits at the end of the history.

Thanks,

--The loon

Other related posts: