[haiku-development] Re: Final Set*UIColor Patch, Version 3e

  • From: looncraz <looncraz@xxxxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Sun, 29 Nov 2015 07:28:51 -0600

On 11/29/2015 05:28, Dario Casalinuovo wrote:

If you want, get out a few fixes from the patchset (even one or two patches of the set), open a ticket and feel free to assign it to me. That's what I can do :-)


Thank you!

I think if you wanted to review anything it would be all the color changes for all the apps themselves. You can make it easy on yourself and use the patch file and search for 4f24a87b650df80e6e85f70135d93578cc7054f7 or the "Chart colors and some font awareness" commit.

From there, most of the patch are changes to individual applications, each commit being applied to a specific application or tests or add-on. The changes are quite often just changing SetViewColor(ui_color(...)) to SetViewUIColor(), but there are quite a few times where the changes are not that simple.

If you go up from that point in the patch (line 8211), then you will find the changes to the client-side of the interface kit

Thanks again!

--The loon

Other related posts: