[procps] Re: top: NUMA node CPU utilization support
- From: Craig Small <csmall-procps@xxxxxxxxxx>
- To: procps@xxxxxxxxxxxxx
- Date: Fri, 26 Apr 2013 08:25:54 +1000
On Thu, Apr 25, 2013 at 04:40:36AM -0500, Jim Warner wrote:
> from the before() function ------------------------------
> #ifndef NUMA_DISABLE
> #ifdef PRETEND_NUMA
> Numa_node_tot = Numa_max_node() + 1;
> #else
> Libnuma_handle = dlopen("libnuma.so", RTLD_LAZY);
> if (Libnuma_handle) {
> Numa_max_node = dlsym(Libnuma_handle, "numa_max_node");
> Numa_node_of_cpu = dlsym(Libnuma_handle, "numa_node_of_cpu");
> if (Numa_max_node && Numa_node_of_cpu)
> Numa_node_tot = Numa_max_node() + 1;
> else {
> dlclose(Libnuma_handle);
> Libnuma_handle = NULL;
> }
> }
> #endif
> #endif
Admittedly this is before my first coffee but previously we had 2 states
- numa disabled = no numa symbols or variables are compiled in
- numa enabled = numa symbols and variables are there with valid
values
Now we have a third
- numa enabled but no library - numa variables with no or invalid
values
So currently any numa related thing is protected by #ifdef NUMA_ENABLED
which remains, but the values or state needs to be checked too.
- Craig
>
>
>
--
Craig Small VK2XLZ http://enc.com.au/ csmall at : enc.com.au
Debian GNU/Linux http://www.debian.org/ csmall at : debian.org
GPG fingerprint: 5D2F B320 B825 D939 04D2 0519 3938 F96B DF50 FEA5
Other related posts:
