Dave that second point is a good one and would be useful for building
liblouis on windows with MSVC. At the moment the windows directory has a
copy of liblouis.h but it keeps getting out of sync with liblouis.h.in
as it seems like people forget to apply changes in both files.
Having a straight forward header with only the define elsewhere would
mean that the MSVC build stuff would be less likely to be out of sync.
Michael Whapples
On 29/12/2015 19:54, Dave Mielke wrote:
I have liblouis building with the Android NDK now. There are two fixes that
could be made:
First, the simple one: I'm probably compiling with more warnings enabled. I'm
getting:
liblouis/compileTranslationTable.c: In function 'resolveTable':
liblouis/compileTranslationTable.c:4650: warning: passing argument 1 of
'copyStringArray' from incompatible pointer type
liblouis/compileTranslationTable.c:4629: note: expected 'const char **' but
argument is of type 'char **'
This, of course, could easily be fixed. I can do it. Would you prefer that I
post a patch to this mailing list, or would you be willing to add me (github
user DaveMielke) as a developer so that I can push it. Or, maybe, you'd prefer
some other method.
For those who don't know me, I'm the administrator of BRLTTY:
http://brltty.com/
Now, for the more complicated one: The liblouis.h header needs to be derived
from liblouis.h.in for exactly one small reason:
#define widechar @WIDECHAR_TYPE@
Is this because having liblouis.h include config.h is seen as undesirable? As I
see it, either liblouis.h could include config.h or it could include some other
very small header that just #defines widechar. This would eliminate the need to
save a whole separate copy of liblouis.h just for that one line.
