[haiku-bugs] Re: [Haiku] #10134: DriveSetup: some new functions

  • From: "stippi" <trac@xxxxxxxxxxxx>
  • Date: Wed, 11 Dec 2013 20:31:46 -0000

#10134: DriveSetup: some new functions
   Reporter:  dsjonny                  |      Owner:  stippi
       Type:  enhancement              |     Status:  new
   Priority:  normal                   |  Milestone:  R1
  Component:  Applications/DriveSetup  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All

Comment (by stippi):

 Hm, the patch has massive coding style problems. It is both violations
 against the style guide (names like "v" and "enc", wrong if/else
 formatting, and so on), as well as structural (mostly factoring out small
 functions which serve a singular purpose and are named accordingly).

 I don't feel like pointing out all the violations and what I would do
 differently. Just supply me with an updated patch and I'll try to find the
 time to work over it. If you feel like it, you can look at what I changed,
 it should be in a separate commit I suppose, so you can look at the diff.
 Please don't take it the wrong way, I really appreciate all the work which
 went into this and want to apply it!

Ticket URL: <http://dev.haiku-os.org/ticket/10134#comment:4>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: