[haiku-bugs] Re: [Haiku] #10134: DriveSetup: some new functions

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Mon, 16 Dec 2013 14:22:18 -0000

#10134: DriveSetup: some new functions
   Reporter:  dsjonny                  |      Owner:  stippi
       Type:  enhancement              |     Status:  new
   Priority:  normal                   |  Milestone:  R1
  Component:  Applications/DriveSetup  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All

Comment (by korli):

 Replying to [comment:7 dsjonny]:
 > The "register_file_disk_device" and the code you pasted in are from the
 diskimage command's source code:
 > http://cgit.haiku-os.org/haiku/tree/src/bin/diskimage.cpp

 Fine. The printf() call isn't here anymore in your patch, but the comment
 "print the success message" still is. I think you could just skip the part
 from the comment to the end of the method (except for the return
 statement) as it's just informative.
 Note that the partition list item should be updated with the mount path
 (if any)

Ticket URL: <http://dev.haiku-os.org/ticket/10134#comment:9>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: