[haiku-bugs] Re: [Haiku] #10134: DriveSetup: some new functions

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Tue, 17 Dec 2013 11:27:12 -0000

#10134: DriveSetup: some new functions
---------------------------------------+----------------------------
   Reporter:  dsjonny                  |      Owner:  stippi
       Type:  enhancement              |     Status:  new
   Priority:  normal                   |  Milestone:  R1
  Component:  Applications/DriveSetup  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All
---------------------------------------+----------------------------

Comment (by korli):

 Unfortunately, not all the problems:
 * commit message: 1 line then a blank line, then the rest.
 * DiskView.cpp: lines 93, 103, 107, 111, 115, 126, 130, 134, 138: the else
 if statement goes on the previous line.
 * DiskView.cpp: line 143: "fUsed = 100.0;" goes on the next line. Same for
 lines 149-154, 185-187, 197, 216-218, 251-253, 341
 * MainWindow.cpp: you can remove lines 431-441.
 * MainWindow.cpp: lines 561, 568, 580, 587, 599, 605, 627, 650, 662, 672,
 678, 700, 807, 834 too long.
 * PartitionList.cpp: lines 279, 284, 289, 294, 364: the else if statement
 goes on the previous line (or the else alone).
 * PartitionList.cpp: line 384: the statement after the if goes on the next
 line.

 Maybe you could try http://cgit.haiku-
 os.org/haiku/tree/src/tools/checkstyle to help.

--
Ticket URL: <http://dev.haiku-os.org/ticket/10134#comment:11>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: