[haiku-bugs] Re: [Haiku] #10134: DriveSetup: some new functions

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Mon, 16 Dec 2013 08:06:38 -0000

#10134: DriveSetup: some new functions
   Reporter:  dsjonny                  |      Owner:  stippi
       Type:  enhancement              |     Status:  new
   Priority:  normal                   |  Milestone:  R1
  Component:  Applications/DriveSetup  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All

Comment (by korli):

 Replying to [comment:5 dsjonny]:
 > I have created again the patch.
 > +Added LUKS encryption detection.

 Coding style problems still apply on this new patch (names like "v" and
 "e", wrong if/else formatting). Also "register_file_disk_device" is not a
 valid method name, "RegisterFileDiskDevice" is.

 I'm also wondering whether something is missing in the following code:
         // print the success message (get the device path)
         BDiskDevice device;
         BPath path;
         if (roster.GetDeviceWithID(id, &device) == B_OK
           && device.GetPath(&path) == B_OK) {
         } else {
 AFAICS the path isn't used on success.

Ticket URL: <http://dev.haiku-os.org/ticket/10134#comment:6>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: