[haiku-bugs] Re: [Haiku] #10134: DriveSetup: some new functions

  • From: "korli" <trac@xxxxxxxxxxxx>
  • Date: Tue, 17 Dec 2013 13:31:18 -0000

#10134: DriveSetup: some new functions
   Reporter:  dsjonny                  |      Owner:  stippi
       Type:  enhancement              |     Status:  new
   Priority:  normal                   |  Milestone:  R1
  Component:  Applications/DriveSetup  |    Version:  R1/Development
 Resolution:                           |   Keywords:
 Blocked By:                           |   Blocking:
Has a Patch:  1                        |   Platform:  All

Comment (by korli):

 Thanks, still occurrences in MainWindow.cpp lines 611, 612, 614, 689, 690,
 692, 834, 876, 1127, 1128 and PartitionList.cpp lines 296-300, 309.

 There is also a typo MainWindow.cpp line 591.

 Functionnally, my remarks:
 * You should also launch DiskProbe by signature and fallback to the path
 with PathFinder/find_path().
 * On alerts, it seems there is no modal alert during the copy/save
 process, just before and after.
 * In MainWindow.cpp line 604, the buffer is leaked. Also why are you using
 exceptions here? There is also no error alert on copy failure.
 * Once the partition is written, is there any code to let the
 DiskDeviceManager refresh this partition status?
 * In SaveDiskImage() and WriteDiskImage(), you should also consider
 checking all status returned by functions, and initializing pointers to
 NULL. These methods are critical and shouldn't misbehave.

Ticket URL: <http://dev.haiku-os.org/ticket/10134#comment:13>
Haiku <http://dev.haiku-os.org>
Haiku - the operating system.

Other related posts: