Hi Phuc,
The link you provided before does not work anymore:
http://saomaicenter.org/en/blog/accessible-formats/rules-and-guidelines-
vietnamese-braille. Do you have an alternative link? Or better, do you have
a document that we could put on our own space?
I also have a few more remarks after looking more closely at your PR.
- Is it really necessary to copy the ueb-math table? Wouldn't it be better
to include the existing one? If it is really important that the behavior of
the table is stable, a better solution is to create regression tests.
- It looks like you also copied parts of other UEB tables without
mentioning anything about it in your table, and you even gave yourself
copyright to it. You shouldn't do that. Again, I would suggest to either
include an original UEB table, or create regression tests.
- You mention in your tables that you got help from Benedict and Pyae
Phyopaing for Myanmar, and Khemara Ly for Khmer. In your previous email you
also mention Myanmar Assistive Tech Research & Dev Center and the Myanmar
Association of the Blind, and the Krausao-mei school in Cambodia. How are
these people related?
As a general remark, I strongly encourage you to write tests for your
tables because it has nothing but benefits.
<http://saomaicenter.org/en/blog/accessible-formats/rules-and-guidelines-vietnamese-braille>
Op ma 7 jan. 2019 om 22:36 schreef Bert Frees <bertfrees@xxxxxxxxx>:
Ok thanks.
Op ma 7 jan. 2019 om 18:11 schreef Dang Hoai Phuc <danghoaiphuc@xxxxxxxxx
:
Hi Bert,
Thanks for your help pulling the tables to LibLouis.
Fyi, the Vi-south.ctb table is actually the full contracted Vietnamese.
As you might know, we had two political systems before 1975 and we have two
different contracted Braille versions. The uncontracted version is used
same for the whole country.
The vi-vn-g1 and vi-vn-g2 are officially used by the government. However,
the South one is still used by many visually impaired people based in the
South so I decided that it should be given as I believe they have right to
choose to read with any Braille codes that they want. For the official
document of Vietnamese Braille codes, I have published on our website at:
http://saomaicenter.org/en/blog/accessible-formats/rules-and-guidelines-vietnamese-braille
For the Braille tables for Myanmar and Khmer languages, I got the Braille
signs from the colleagues: Myanmar (Myanmar Assistive Tech Research & Dev
Center and the Myanmar Association of the Blind) and the Khmer from the
Krausao-mei school in Cambodia.
Please let me know for any further info.
Best,
Phuc
On 1/7/2019 10:47 PM, Bert Frees wrote:
Hello Phuc,
Thanks! That sounds great. I have made a pull request from your files:
https://github.com/liblouis/liblouis/pull/683. I have also added some
observations. Please have a look.
I have some questions regarding the vi-south-g2.ctb table. Is this a
variant of the other Vietnamese braille system, or should it be considered
a completely different system? Is the difference explained by a difference
between the dialects, or is it purely historical and could both regions use
the same braille system? Can the regions where this system is used be
pinpointed exactly? Is it fully contracted braille or should it be called
partially contracted, in accordance with vi-vn-g2.ctb?
Some official documentation would help. I am looking for the best way for
a computer to distinguish the braille systems. If the regions where they
are used can be identified exactly, we can use that. Otherwise we need to
give the systems (or variants) distinct names.
Op vr 14 dec. 2018 om 13:15 schreef Dang Hoai Phuc <
danghoaiphuc@xxxxxxxxx>:
Dear Bert, Christian and all Liblouis Developers,
I would like to contribute new translation tables for Burmese, Khmer and
Vietnamese languages which I have created recently. Please give me a
hand to check and commit to the Github. The link to download tables:
https://www.dropbox.com/s/972hy2yypjgxx6o/Braille%20Tables.zip?dl=0
Fyi, it contains the following tables:
For Khmer (Cambodia): kh-g1.ctb (uncontracted Braille)
Burmese for both uncontracted and contracted: mm-g1.ctb and mm-g2.ctb
Vietnamese for uncontracted, partial contracted, full contracted and
South contracted version (used by many adults in the Southern part of
Vietnam): vi-vn-g1.ctb, vi-vn-g2.ctb, vi-vn-g3.ctb and vi-south-g2.ctb
So the total is 7 new tables. I haven't checked much with backward
translation so your help should be highly appreciated.
With best regards,
Phuc
