[beports] Re: [RFC] cURL patch


Am 25.05.2008 um 09:47 schrieb scott mc:
On Sat, May 24, 2008 at 12:36 AM, Andreas Färber <andreas.faerber@xxxxxx > wrote: 
Please review the following patch against cURL[1] CVS:
http://tools.assembla.com/BePorts/browser/BePorts/trunk/net-misc/curl/curl-CVS.diff?rev=69
(It still applies to HEAD despite a change in lib/select.c, so I didn't 
upload the latest.)
I've incorporated Scott's suggestion of simplifying the #ifdef __BEOS__ section. I must've overlooked that sys/socket.h was already properly being 
included above.
I would like to submit these blockers upstream asap to get them out of my queue. Further changes could then be submitted at a later point in time if 
necessary. So please review the provided changes only:
The patch adds a check for libnetwork, prior to the check for libnet, and it 
works around an #ifdef __BEOS__ section.

Signed-off-by: Andreas Faerber <andreas.faerber@xxxxxx>
Signed-off-by: Scott McCreary <scottmc2@xxxxxxxxx>


Wasn't there someone who got upset about using the ( ) around the
__BEOS__ when they aren't needed.  I guess it would depend on the
coding guidelines of the project that's involved?
Don't get me wrong, I personally like brackets, so I don't get upset about them. Four lines above they used them, too, so I assume it to be their coding style. 


Other than that it
looks good to me.


Thanks,

Andreas
--
BePorts homepage - http://tools.assembla.com/BePorts
List archives: http://www.freelists.org/archives/beports
Administrative contact: brecht@xxxxxxxxxxx

Other related posts: