[beports] Re: [RFC] cURL patch
- From: "scott mc" <scottmc2@xxxxxxxxx>
- To: beports@xxxxxxxxxxxxx
- Date: Sun, 25 May 2008 00:47:24 -0700
On Sat, May 24, 2008 at 12:36 AM, Andreas Färber <andreas.faerber@xxxxxx> wrote:
> Hello,
>
> Please review the following patch against cURL[1] CVS:
> http://tools.assembla.com/BePorts/browser/BePorts/trunk/net-misc/curl/curl-CVS.diff?rev=69
> (It still applies to HEAD despite a change in lib/select.c, so I didn't
> upload the latest.)
>
> I've incorporated Scott's suggestion of simplifying the #ifdef __BEOS__
> section. I must've overlooked that sys/socket.h was already properly being
> included above.
>
> I would like to submit these blockers upstream asap to get them out of my
> queue. Further changes could then be submitted at a later point in time if
> necessary. So please review the provided changes only:
>
> The patch adds a check for libnetwork, prior to the check for libnet, and it
> works around an #ifdef __BEOS__ section.
>
> Signed-off-by: Andreas Faerber <andreas.faerber@xxxxxx>
> Signed-off-by: Scott McCreary <scottmc2@xxxxxxxxx>
>
> Please add your Acked-by: when you've reviewed it.
>
> Thanks,
>
> Andreas
>
> [1] http://tools.assembla.com/BePorts/wiki/net-misc/curl
>
>
> --
> BePorts homepage - http://tools.assembla.com/BePorts
> List archives: //www.freelists.org/archives/beports
> Administrative contact: brecht@xxxxxxxxxxx
>
Wasn't there someone who got upset about using the ( ) around the
__BEOS__ when they aren't needed. I guess it would depend on the
coding guidelines of the project that's involved? Other than that it
looks good to me.
-scottmc
--
BePorts homepage - http://tools.assembla.com/BePorts
List archives: //www.freelists.org/archives/beports
Administrative contact: brecht@xxxxxxxxxxx
Other related posts:
