[beports] Re: [RFC] cURL patch

  • From: "François Revol" <revol@xxxxxxx>
  • To: beports@xxxxxxxxxxxxx
  • Date: Sun, 25 May 2008 18:11:42 +0200 CEST

> >
> > Signed-off-by: Andreas Faerber <andreas.faerber@xxxxxx>
> > Signed-off-by: Scott McCreary <scottmc2@xxxxxxxxx>
> >
> > Please add your Acked-by: when you've reviewed it.
> >
> > Thanks,
> >
> > Andreas
> >
> > [1] http://tools.assembla.com/BePorts/wiki/net-misc/curl
> >
> >
> > --
> > BePorts homepage - http://tools.assembla.com/BePorts
> > List archives: //www.freelists.org/archives/beports
> > Administrative contact: brecht@xxxxxxxxxxx
> >
>
> Wasn't there someone who got upset about using the ( ) around the
> __BEOS__ when they aren't needed.  I guess it would depend on the
> coding guidelines of the project that's involved?  Other than that it
> looks good to me.

I don't recall seeing #if defined without them anywhere...

Btw, I had to fix the patch the other day as I needed cURL in Zeta for
NetSurf... some checks were wrong.
but I used the release one, and I didn't have a look at this one yet.

François.

--
BePorts homepage - http://tools.assembla.com/BePorts
List archives: //www.freelists.org/archives/beports
Administrative contact: brecht@xxxxxxxxxxx

Other related posts: