[beports] Re: [RFC] cURL patch
- From: Ingo Weinhold <ingo_weinhold@xxxxxx>
- To: beports@xxxxxxxxxxxxx
- Date: Sat, 24 May 2008 16:10:45 +0200
On 2008-05-24 at 09:36:58 [+0200], Andreas Färber <andreas.faerber@xxxxxx>
wrote:
> Hello,
>
> Please review the following patch against cURL[1] CVS:
> http://tools.assembla.com/BePorts/browser/BePorts/trunk/net-misc/curl/curl-CVS.diff?rev=69
> (It still applies to HEAD despite a change in lib/select.c, so I
> didn't upload the latest.)
>
> I've incorporated Scott's suggestion of simplifying the #ifdef
> __BEOS__ section. I must've overlooked that sys/socket.h was already
> properly being included above.
>
> I would like to submit these blockers upstream asap to get them out of
> my queue. Further changes could then be submitted at a later point in
> time if necessary. So please review the provided changes only:
>
> The patch adds a check for libnetwork, prior to the check for libnet,
> and it works around an #ifdef __BEOS__ section.
Looks good.
> Signed-off-by: Andreas Faerber <andreas.faerber@xxxxxx>
> Signed-off-by: Scott McCreary <scottmc2@xxxxxxxxx>
Acked-by: Ingo Weinhold <ingo_weinhold@xxxxxx>
> Please add your Acked-by: when you've reviewed it.
Do you use some tool that requires it?
CU, Ingo
--
BePorts homepage - http://tools.assembla.com/BePorts
List archives: //www.freelists.org/archives/beports
Administrative contact: brecht@xxxxxxxxxxx
Other related posts:
