Hi, I have cloned the repo and make basic review of master branch:
All criteria (License and Copyright, security and user experience: pass).
Comments
- You may want to update years of copyright to 2016.
- You may want to check some cosmetic aspects in future minor versions,
for instance, check if global multiinstance should be call when no
change is required for this variable and it only needs be checked to see
its value, or not to return "", instead just make return to simplify things.
- As it's just a basic review, may be I'm missing something. I¡m
wondering if scriptCategory is applied to the app module too, or just
the previous class with gestures.
It's all. Specially aspects of translation workflow seem to be
excellently considered, due to comment for translators, and furthermore
doc is not included when using gesture.send, preventing errors if
keystrokes are changed.Good general impression, with a complete reading
of the app module and readme, and also Python sources of buildvars.
Thanks.
El 20/07/2016 a las 9:33, Joseph Lee escribió:
Hi all,----------------------------------------------------------------
I’d like to request basic review for GoldWave 4.0-dev. The source code
can be found at:
https://github.com/josephsl/goldwave
The major change is the use of obj.getChild instead of obj.children, as
well as localization updates for some languages. I recommend creating a
diff between 3.0 and head using git diff 3.0…head.
Why 4.0: although use of getChild would mean 3.5, I decided to increment
the major version as I’m moving the main development repo to GitHub, as
well as to get this add-on reviewed under the new system.
Thanks.
Cheers,
Joseph
