[nvda-addons] Re: GoldWave 4.0-dev: requesting basic review

  • From: "Brian's Mail list account BY" <bglists@xxxxxxxxxxxxxxxx>
  • To: <nvda-addons@xxxxxxxxxxxxx>
  • Date: Wed, 20 Jul 2016 10:31:47 +0100

So does this new version work on the old goldwave and the newer one, and how does one try it?
Brian

bglists@xxxxxxxxxxxxxxxx
Sent via blueyonder.
Please address personal email to:-
briang1@xxxxxxxxxxxxxxxx, putting 'Brian Gaff'
in the display name field.
----- Original Message ----- From: "Joseph Lee" <joseph.lee22590@xxxxxxxxx>
To: <nvda-addons@xxxxxxxxxxxxx>
Sent: Wednesday, July 20, 2016 8:33 AM
Subject: [nvda-addons] GoldWave 4.0-dev: requesting basic review


Hi all,



I'd like to request basic review for GoldWave 4.0-dev. The source code can
be found at:

https://github.com/josephsl/goldwave



The major change is the use of obj.getChild instead of obj.children, as well
as localization updates for some languages. I recommend creating a diff
between 3.0 and head using git diff 3.0.head.



Why 4.0: although use of getChild would mean 3.5, I decided to increment the
major version as I'm moving the main development repo to GitHub, as well as
to get this add-on reviewed under the new system.



Thanks.

Cheers,

Joseph



----------------------------------------------------------------
NVDA add-ons: A list to discuss add-on code enhancements and for reporting bugs.
Community addons are available from: http://addons.nvda-project.org
To send a message to the list: nvda-addons@xxxxxxxxxxxxx
To change your list settings/unsubscribe: 
//www.freelists.org/list/nvda-addons
To contact list moderators: nvda-addons-moderators@xxxxxxxxxxxxx

Other related posts: