I'll make sure my copy on here is past the one mentioned and try it out over
the weekend.
As I say though its still the old 32 bit version I'm using but the only
issue in the ones after .58 are that some sound cards give weird effects
sometimes, which was why I never bothered to update it. I'm now using a USB
sound card so things might well be better with more modern hardware.
Brian
bglists@xxxxxxxxxxxxxxxx
Sent via blueyonder.
Please address personal email to:-
briang1@xxxxxxxxxxxxxxxx, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Joseph Lee" <joseph.lee22590@xxxxxxxxx>
To: <nvda-addons@xxxxxxxxxxxxx>
Sent: Wednesday, July 20, 2016 5:26 PM
Subject: [nvda-addons] Re: GoldWave 4.0-dev: requesting basic review
Hi,
Copyright years: thanks for catching it, will update as part of the version
tag commit.
Script category: I think it should be done for app modules as well so users
can see where a command comes from.
Thanks for the review. The add-on release date will be set for later this
week.
Cheers,
Joseph
-----Original Message-----
From: nvda-addons-bounce@xxxxxxxxxxxxx
[mailto:nvda-addons-bounce@xxxxxxxxxxxxx] On Behalf Of Noelia
Sent: Wednesday, July 20, 2016 7:54 AM
To: nvda-addons@xxxxxxxxxxxxx
Subject: [nvda-addons] Re: GoldWave 4.0-dev: requesting basic review
Hi, I have cloned the repo and make basic review of master branch:
All criteria (License and Copyright, security and user experience: pass).
Comments
- You may want to update years of copyright to 2016.
- You may want to check some cosmetic aspects in future minor versions, for
instance, check if global multiinstance should be call when no change is
required for this variable and it only needs be checked to see its value, or
not to return "", instead just make return to simplify things.
- As it's just a basic review, may be I'm missing something. I¡m wondering
if scriptCategory is applied to the app module too, or just the previous
class with gestures.
It's all. Specially aspects of translation workflow seem to be excellently
considered, due to comment for translators, and furthermore doc is not
included when using gesture.send, preventing errors if keystrokes are
changed.Good general impression, with a complete reading of the app module
and readme, and also Python sources of buildvars.
Thanks.
El 20/07/2016 a las 9:33, Joseph Lee escribió:
Hi all,----------------------------------------------------------------
I'd like to request basic review for GoldWave 4.0-dev. The source code
can be found at:
https://github.com/josephsl/goldwave
The major change is the use of obj.getChild instead of obj.children,
as well as localization updates for some languages. I recommend
creating a diff between 3.0 and head using git diff 3.0.head.
Why 4.0: although use of getChild would mean 3.5, I decided to
increment the major version as I'm moving the main development repo to
GitHub, as well as to get this add-on reviewed under the new system.
Thanks.
Cheers,
Joseph
