[liblouis-liblouisxml] Re: Invalid Russian table file

  • From: Hammer Attila <hammera@xxxxxxxxx>
  • To: liblouis-liblouisxml@xxxxxxxxxxxxx
  • Date: Wed, 19 Dec 2012 07:19:26 +0100

I confirm this, lou_checktable drops 16 errors the ru-ru-comp8 table between 252th and 267th lines. Both 16 errors following the error message: Exactly one Unicode character and at least one cell are required.

For example the 252th line containing following rule:
space \x02219 238               BULLET OPERATOR
Clear seeing the unicode character in the rule are containing five digits.
This table are broken the 2.5.1 prewious Liblouis version too.

I attached a patch with perhaps solve this issue, but a russian table user please test the table this affected characters before commit. John, need releasing a new bugfix release if this patch are good? Peter, you possible testing this table after applied the attached patch? I simple cutted the first 0 digit this affected unicode characters. I verifyed for example the \x02219 character in Gedit, the resulted unicode character is unicode 2219, so I think this fix will be good. Lou_checktable not will be drop errors the new modified table if this patch are committed.

I have got a question before I making the final patch if any changes are needed: not need renaming this table from ru-ru-comp8 to ru-ru-comp8.ctb filename? For example Orca founding only with ru and ru-ru-g1 table, real table filenames is ru.ctb and ru-ru-g1.utb in the Liblouis tables directory.

Attila
Index: tables/ru-ru-comp8
===================================================================
--- tables/ru-ru-comp8  (revision 875)
+++ tables/ru-ru-comp8  (working copy)
@@ -249,19 +249,19 @@
 lowercase \x0463 345           CYRILLIC SMALL LETTER YAT
 uppercase \x046a 2467          CYRILLIC CAPITAL LETTER BIG YUS
 lowercase \x046b 246           CYRILLIC SMALL LETTER BIG YUS
-space \x02219 238              BULLET OPERATOR
-punctuation \x0221a 568                SQUARE ROOT
-punctuation \x02248 358                ALMOST EQUAL TO
-space \x02264 4568             LESS-THAN OR EQUAL TO
-space \x02265 35678            GREATER-THAN OR EQUAL TO
-punctuation \x02320 2568               TOP HALF INTEGRAL
-punctuation \x02321 258                BOTTOM HALF INTEGRAL
-punctuation \x02580 348                UPPER HALF BLOCK
-punctuation \x02584 468                LOWER HALF BLOCK
-punctuation \x02588 68         FULL BLOCK
-punctuation \x0258c 278                LEFT HALF BLOCK
-punctuation \x02590 2378               RIGHT HALF BLOCK
-punctuation \x02591 3578               LIGHT SHADE
-punctuation \x02592 267                MEDIUM SHADE
-punctuation \x02593 3568               DARK SHADE
-punctuation \x025a0 23568              BLACK SQUARE
+space \x2219 238               BULLET OPERATOR
+punctuation \x221a 568         SQUARE ROOT
+punctuation \x2248 358         ALMOST EQUAL TO
+space \x2264 4568              LESS-THAN OR EQUAL TO
+space \x2265 35678             GREATER-THAN OR EQUAL TO
+punctuation \x2320 2568                TOP HALF INTEGRAL
+punctuation \x2321 258         BOTTOM HALF INTEGRAL
+punctuation \x2580 348         UPPER HALF BLOCK
+punctuation \x2584 468         LOWER HALF BLOCK
+punctuation \x2588 68          FULL BLOCK
+punctuation \x258c 278         LEFT HALF BLOCK
+punctuation \x2590 2378                RIGHT HALF BLOCK
+punctuation \x2591 3578                LIGHT SHADE
+punctuation \x2592 267         MEDIUM SHADE
+punctuation \x2593 3568                DARK SHADE
+punctuation \x25a0 23568               BLACK SQUARE

Other related posts: