[haiku-development] Re: app_server patch

  • From: Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx>
  • To: haiku-development@xxxxxxxxxxxxx
  • Date: Wed, 13 Apr 2011 19:33:48 +0200

Am 13.04.2011 um 09:47 schrieb Joseph Groover:

> ALL opinions wanted!

There are some code style violations. See [1] for details.

For example:
* no spaces around a condition:
  if (condition) instead of if ( condition )
* opening curly bracket on same line after conditional statement:
  if (condition) { ... 
* I think it is preferred to explicitly test against NULL or 0:
  point == NULL or point != NULL instead of !pointer or pointer
  strcmp(...) != 0 instead of !strcmp(...)
* The * belongs to the type:
  DecorAddOn* name instead of DecorAddOn * name
* Local variable names are not aligned:
        DecorAddOn* old_decor = fCurrentDecor;
        BString old_path = fCurrentDecorPath;
        image_idold_image = fCurrentDecor->ImageID();
  instead of:
        DecorAddOn      * old_decor = fCurrentDecor;
        BString         old_path        = fCurrentDecorPath;
        image_id        old_image       = fCurrentDecor->ImageID();
* I think we don't use underscores in variable names
  oldDecor instead of old_decor
* use find_directory with B_USER_ADDONS_DIRECTORY instead of the hard coded 
path in:
  #define DECORATORS_DIR "/boot/home/config/add-ons/decorators/"

[1] http://www.haiku-os.org/development/coding-guidelines

Other related posts: