[haiku-commits] Re: haiku: hrev44039 - src/kits/interface headers/os/interface src/preferences/keymap

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Wed, 18 Apr 2012 22:08:05 +0200

On 17.04.2012 19:59, John Scipione wrote:
On Tue, Apr 17, 2012 at 12:45 PM, Axel Dörfler <axeld@xxxxxxxxxxxxxxxx
<mailto:axeld@xxxxxxxxxxxxxxxx>> wrote:
> John, I hope you are aware that your reply style is absolutely
> unacceptable.
Look, I'm sorry that you find my style of response unacceptable, I
actually thought Emerson added something apropos to the discussion, [...]

I did not know that quote, so I couldn't recognize it as such. While that puts your reply in a different light, the last sentence "I wonder what keeps you up at night" doesn't really improve things.

I am a bit frustrated that you immediately rejected the idea telling me
to revert it without even giving it a look judging from the delay time
of your response from the time of my push.

You do remember you had send screenshots of those two apps before?

It is doubly frustrating that you only bring this up after the fact, not
before when I was discussing the idea on the rounded button thread
earlier. It should not have come as a surprise to anyone that I intended
to make this change.

How should I have known? While you mentioned that you were doing this for Keymap/DeskCalc in particular, you were quickly broadening the scope of your work. You did not really mention your plans in detail.
Besides that, I had nothing to add to Stippi's post:
//www.freelists.org/post/haiku-development/RoundRect-ButtonFrame,71

I don't know what you made of that, but after you stated that stippi should decide the matter, I didn't (and really couldn't) assume you would do it this way.

> Can you please explain why those two applications should look
> different from other applications that are part of Haiku? Why should
> the fact that they resemble real world devices be a good reason?
In the case of Deskcalc and Keymap the design of the app is made in such
a way that it resembles an analog of a real world device, specifically a
desktop calculator and a computer keyboard. These devices tend to have
slightly rounded buttons on them, so, this stylistic choice was made to
show the connection more readily.

You did not really answer my question. Why should that connection be made more obvious? What good does it do?

[...]
Given all these examples it would be inconsistent for me to NOT attempt
to style these interface elements to look a bit more like the device
they are meant to emulate. Either that or the developers of the above
applications all made this same mistake I did.

I've nothing to add to Ingo's answer in that regard.

> Of course, 100% consistency can never be reached as it's not always
> possible or the best way. However, you should always have a very
> good reason for leaving that path.
Now, if you have a problem with the way my design looks, okay, I can
accept that. Tell me it's ugly and you hate it, tell me how it doesn't
work for this reason or that. But don't just blanket reject it because
it is inconsistent.

I've tested it now, and I don't like how it works now: especially when the buttons are small, it looks pretty bad. I think the strength of the rounded corner must depend on the size of the button, with really large buttons it looks okay, but it should be much more subtle with normal button sizes.

On 18.04.2012 10:24, Stephan Aßmus wrote:
> Forgot to mention: The effect of this change is also that the
> keyboard is more presented as the "content" that is controlled
> by this preflet, and it is better separated from the surounding
> controls. So I think the change here really adds some value.

I did not think of that, and that's actually a good argument speaking for keeping this change, at least once the effect is made more subtle.

Bye,
   Axel.

Other related posts: