[haiku-commits] Re: haiku: hrev44039 - src/kits/interface headers/os/interface src/preferences/keymap

  • From: Axel Dörfler <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 16 Apr 2012 09:32:05 +0200

On 16.04.2012 08:30, jscipione@xxxxxxxxx wrote:
   * Updated Deskcalc and Keymap to use buttons with rounded corners.

While the rounded corners don't look bad, the interface should stay consistent. Please revert that part of the commit again.

   * Overloaded methods with radium parameters are not virtual right
     now so as to not break vtables. Added /*virtual*/ before each
     method that should be made virtual in ControlLook.h

When you fix that, make sure you'll add quite a bunch of reserved virtual slots for the next time.

+       // reset clipping constraints
        view->ConstrainClippingRegion(NULL);
  }

I know it's not your code, but is it a good idea to change the views clipping region outside of the view state push/pop?

Bye,
   Axel.

Other related posts: