[haiku-appserver] Re: Refactoring

  • From: Adi Oanca <adioanca@xxxxxxxxxxxxx>
  • To: haiku-appserver@xxxxxxxxxxxxx
  • Date: Tue, 28 Jun 2005 11:22:08 +0300


Stephan Aßmus wrote:
resolution, color space etc. I know that some of you had something different in mind at first, but again, just look at the code, it is just obvious where it goes from there. Maybe we can rename it to PhysicalScreen if that makes everybody more happy.

Yup :)

Second, I really love the idea to think of a Workspace as a container for a certain configuration of the physical screen(s). When multiple independant physical screens are supported, one Workspace will represent a certain setting of _all_ the screens.

Um, I think what I described in my previous mail is a bit clearer. If you put all that you said in Workspace, it will complicate code as Workspace code will be needed somewhere in the DisplayDriver to know where to draw lines and rects.

Third... DarkWyrm and Adi keep mentioning that the code has to be the way it is, and that it being complicated is because of the complexity of the app_server. Sorry, but I have to disagree. The app_server really has _no_ reason of being so hard to understand as it currently is for a new developper joinging the team. And this really hurts development.

No, I don't say that.
When DW got to work on the app_server, he didn't know exactly the requirements and _how_ things should be done. As a prof he started with prototypes. Same happened to me. When I came to work on the app_server DW just released proto7. We did what we could on the server and I'm very glad we pulled this up. There were *a lot* of changes. We frequently changed the design to accommodate the needs for that particular moment. That's why there are a lot of friends in app_server classes. I know the time for a cleanup was near because ATM almost all requirements are known and app_server is at a point when it really does something useful.

Everyone having come to the team had this first impression. The code containing so many errors is just proof of it. Please, I don't mean to hurt anyones feelings.

No you don't. For me this is the first big project that I attend on. I learned *A LOT* during this time, and I know I have more to learn. Hack, I'm only 24, you and Axel are 28+, it's clear you guys know more. ;-)

bye, Adi.

Other related posts: