[ZeroBrane Studio] Re: Search redesign for ZBS
- From: Derek Bailey <dbaileychess@xxxxxxxxx>
- To: zerobrane <zerobrane@xxxxxxxxxxxxx>
- Date: Mon, 30 Mar 2015 11:11:28 -0700
Paul,
I think the location of the search results in the bottom panel is ideal,
see #2 from my original post :) It would behave very similarly to Notepad++.
Take Care,
Derek
On Mon, Mar 30, 2015 at 10:54 AM, Paul K <paul@xxxxxxxxxxxxx> wrote:
> > Could you make it asymmetric as well?
> > search.contextlinesbefore = 2
> > search.contextlinesafter = 2
>
> It's definitely possible, although I'm not sure how frequently used
> it's going to be.
>
> > The issue I have with copying the results, if you create a new editor,
> it names the tab 'untitled.lua', which automatically turns on syntax
> highlighting which gives odd results for the pasted material. Also, the
> code folding is completely broken when you copied the results to a new
> editor; it doesn't preserve the file-by-file folding at all.
>
> Good points; I was thinking mostly in terms of the content, but not
> its presentation.
>
> I may consider a switch that will allow to have multiple Search Result
> windows (one by default), but I foresee a number of challenges related
> to that. If you search for `1`, get a Search Results page, and then
> try to search for `1` inside that page, you'll get false positives on
> line numbers and some other content on that page. I was thinking about
> improving that (so only the line matches are searched), but this
> requires keeping track of all windows with search results (and not
> just the last one). It also makes the UI more cumbersome as when you
> switch between search results and try to do Find Next, it will only
> use the currently selected search string, not what the search string
> was for that window. And so on. It gets even trickier (and error
> prone, both in terms of testing and user interaction) for replace in
> files. One fix would be to only allow any kind of "special"
> interaction in the last results window and nowhere else.
>
> > Also, you lose the context of the term you searched. Perhaps you could
> put the search term at the bottom of the search results window:
> > Searched for: "c[a]t"
> > Found 5 instance(s) on 3 line(s) in 2 file(s).
>
> Yes, I can do that; either top or the bottom of that page will do.
>
> >> In terms of the split tabs, I'll probably keep it as is, but if you
> >> split it yourself, I'll make it to remember the position of the tab
> >> and will restore the split. This will be added at the same time when
> >> the settings are going to be saved.
> >
> > Is there a way to add the Search Results window to the View menubar
> menu, so we can toggle it on and off with a keyboard shortcut?
>
> Probably not, but I'm thinking not that maybe a better location for
> the search results will be a separate tab at the bottom panel (next to
> Output/Console) tabs. It can be split into a separate tab at the
> bottom or dragged out to make a separate window. You won't be able to
> join it with the rest of the editor tab, but maybe none of that is
> needed. You can still search inside that tab, but I'm thinking that it
> may be better location for it (as it will allow for more space in the
> tab to include the search string and will potentially be a better
> place for multiple search results tabs). This would avoid any need for
> splitting the tabs to show results.
>
> This location may also work better for the search result navigation;
> I'm thinking of using F4/Shift-F4 to jump between matches, which would
> open a file and position the cursor to the match.
>
> Thoughts?
>
> Paul.
>
>
Other related posts:
