commit/placeMarkers: 2 new changesets

  • From: commits-noreply@xxxxxxxxxxxxx
  • To: nvda-addons-commits@xxxxxxxxxxxxx
  • Date: Fri, 12 May 2017 17:11:11 -0000

2 new commits in placeMarkers:

https://bitbucket.org/nvdaaddonteam/placemarkers/commits/fac629528c65/
Changeset:   fac629528c65
Branch:      None
User:        norrumar
Date:        2017-05-12 16:51:27+00:00
Summary:     Removed some debugging code

Affected #:  1 file

diff --git a/addon/globalPlugins/placeMarkers/__init__.py 
b/addon/globalPlugins/placeMarkers/__init__.py
index 044b127..a103866 100644
--- a/addon/globalPlugins/placeMarkers/__init__.py
+++ b/addon/globalPlugins/placeMarkers/__init__.py
@@ -509,7 +509,6 @@ class Note(object):
                super(Note, self).__init__()
                self.title = title
                self.body = body
-               self.text = ""
 
 ### Global plugin
 
@@ -653,11 +652,6 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
                count = len(start.text)
                bookmarks = getSavedBookmarks()
                positions = bookmarks.keys()
-               #if count in positions and not hasattr(obj,'selection'):
-                       #ui.message(
-                               # Translators: message presented when the 
current position was previously saved as a bookmark.
-                               #_("This position was already saved"))
-                       #return
                noteTitle = 
obj.makeTextInfo(textInfos.POSITION_SELECTION).text[:100].encode("mbcs")
                bookmarks[count] = Note(noteTitle)
                fileName = getFileBookmarks()
@@ -696,8 +690,7 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
                except (NotImplementedError, RuntimeError):
                        ui.message(
                                # Translators: Message presented when a 
bookmark can't be deleted.
-                               #
-                       _("Bookmark cannot be deleted"))
+                               _("Bookmark cannot be deleted"))
                        return
                start.setEndPoint(end, "endToStart")
                count = len(start.text)


https://bitbucket.org/nvdaaddonteam/placemarkers/commits/7c8e0e3acb84/
Changeset:   7c8e0e3acb84
Branch:      8.0-dev
User:        norrumar
Date:        2017-05-12 17:09:55+00:00
Summary:     Preserve the body of saved notes when saving them again changing 
the title selecting other piece of text

Affected #:  1 file

diff --git a/addon/globalPlugins/placeMarkers/__init__.py 
b/addon/globalPlugins/placeMarkers/__init__.py
index a103866..d43c38d 100644
--- a/addon/globalPlugins/placeMarkers/__init__.py
+++ b/addon/globalPlugins/placeMarkers/__init__.py
@@ -651,9 +651,9 @@ class GlobalPlugin(globalPluginHandler.GlobalPlugin):
                start.setEndPoint(end, "endToStart")
                count = len(start.text)
                bookmarks = getSavedBookmarks()
-               positions = bookmarks.keys()
                noteTitle = 
obj.makeTextInfo(textInfos.POSITION_SELECTION).text[:100].encode("mbcs")
-               bookmarks[count] = Note(noteTitle)
+               noteBody = bookmarks[count].body
+               bookmarks[count] = Note(noteTitle, noteBody)
                fileName = getFileBookmarks()
                try:
                        cPickle.dump(bookmarks, file(fileName, "wb"))

Repository URL: https://bitbucket.org/nvdaaddonteam/placemarkers/

--

This is a commit notification from bitbucket.org. You are receiving
this because you have the service enabled, addressing the recipient of
this email.

Other related posts: