[linux-cirrus] Re: EP93xx patch against linux-2.6.12 is out!
- From: Michael Burian <dynmail1@xxxxxxxxxxxxxxxxx>
- To: linux-cirrus@xxxxxxxxxxxxx
- Date: Mon, 04 Jul 2005 08:03:42 +0200
Jean-Philippe Francois wrote:
> On Fri, 2005-07-01 at 16:17, Michael Burian wrote:
>
>>Jean-Philippe Francois wrote:
>>
>>>Thanks a lot for this.
>>>I don't like the IO_ADDRESS() thing, but I can live with it :)
>>
>>better ideas?
>
> Dropping it ;)
> More seriously, I think replacing inl(addr) with readl(IO_ADDRESS(addr))
> reduces the code readability.
agree
> If we had EP93XX_AHB_BASE defined as IO_BASE_VIRT, we could get rid of
> this IO_ADDRESS macro.
>
before replacing 400+ lines again, is there some evidence[1] apart from
"beauty" that this is the right thing(tm)?
To put it the other way, are you absolutely sure that the physical
address will never be needed, not even in .id fields, etc?
[1] other archs doing it that way, some discussion on linux-arm-kernel, ...
Other related posts:
