[linux-cirrus] Re: EP93xx patch against linux-2.6.12 is out!
- From: Michael Burian <dynmail1@xxxxxxxxxxxxxxxxx>
- To: linux-cirrus@xxxxxxxxxxxxx
- Date: Fri, 08 Jul 2005 11:46:40 +0200
Robert Whaley wrote:
>
OK - Things went well without PCMCIA, but after a quick look at the
board specific part I'd say things are quite different when compared
with the EDB9315 board.
I skimmed through the adssphere and mainstone implementation, but I'm
not that much of a PCMCIA expert to get it going within a reasonable
amount of time.
This means I'm unable to try PCMCIA myself until somebody provides me
with an edb9315 specific board file. I can help with testing then.
>
> This IOCTL is asking about bad blocks on the on-board flash. The
> current MTD layer doesn't support bad blocks checking, so it returns
> -EOPNOSUPP when this ioctl is called.
AFAICT your patch prevents the driver from telling the truth. Patch the
kernel to tell some convenient lie, and userspace apps probably never
get fixed. If you insist on getting this patch in, please let's continue
on linux-arm-kernel.
Status: patch rejected
>
> The current 'erase' and 'eraseall' commands from Debian, use this IOCTL.
> These commands fail if the IOCTL returns -EOPNOTSUPP.
>
> Probably the better thing to do would be to fix these commands so that
> they continue to erase even when -EOPNOTSUPP is returned.
indeed
Please check if the problem is still present in the latest version
mtd-tools. If yes, we should discuss this with mtd folks.
I had a quick look[1] and it all looks sane, should not be too difficult
to fix.
[1]
apt-get --build source mtd-tools
>
>
> You should also carefully review the changes the patch makes to:
>
> touchscreen (changed input API returns to allow X11 and
> nanox/microwindows to work with tslib and with real (USB) mice),
I consider this to be a bugfix and nobody depends on the former,
broken behavoir.
In case I'm wrong here, we need to revert this patch and think about
some other (configurable) solution that makes both sides happy.
Unfortunately I haven't got a touchscreen to try for myself.
Status: patch applied
>
> framebuffer (finished adding LQ64D343, check for and use of fb already
> setup by bootloader, and removal of a -1 where it was causing loss of a
> line), and,
works for me, consider it applied.
If also fixed a timing setting for the 320x240 LCD, btw.
Status: patch applied
>
> ethernet (move MAC address macro from init to open time and code to get
> mac address from I2C eeprom) to make sure they are right for what you
> want to do.
It's OK with me, complaints anybody else?
Status: patch applied
> To make sure these are generally acceptable. (Note that some folks are
> strongly opposed to using the FB configured by the bootloader and
> believe that linux should always configure devices from scratch. But we
> find this to be very useful since we have to support many different
> panels and can easily setup the FB parameters to whatever we need before
> Linux starts).
>
As with all the other drivers, RMK will have the last word on it.
Let's hope he'll like it.
Other related posts:
