[liblouis-liblouisxml] AW: Re: segfault with very long table lists
- From: "Bijewitz, Volker" <v.bijewitz@xxxxxxx>
- To: <liblouis-liblouisxml@xxxxxxxxxxxxx>
- Date: Thu, 29 Apr 2010 09:23:59 +0200
Hi,
I do not think that it is very bad to increase MAXSTRING to 512. Browsing the
code, I found 3 static strings and one static FileInfo struct, the other
occurances seems to be local variables on the stack. One or to kb more
statically allocated memory seems to me no big problem in my case, I use
libLouis only on the PC.
Thanks,
Volker
> -----Ursprüngliche Nachricht-----
> Von: liblouis-liblouisxml-bounce@xxxxxxxxxxxxx
> [mailto:liblouis-liblouisxml-bounce@xxxxxxxxxxxxx] Im Auftrag
> von John J. Boyer
> Gesendet: Mittwoch, 28. April 2010 17:14
> An: liblouis-liblouisxml@xxxxxxxxxxxxx
> Betreff: [liblouis-liblouisxml] Re: segfault with very long
> table lists
>
> I don't think ViewPlus will have any problem, but Baum might.
> One possibility would be to make the size of MAXSTRING a
> configuration option, with the default being 256.
>
> John
>
> On Wed, Apr 28, 2010 at 04:48:27PM +0200, Christian Egli wrote:
> > Hi
> >
> > "John J. Boyer" <john.boyer@xxxxxxxxxxxxxxxxx> writes:
> >
> > > Increasing MAXSTRING to 512 looks ok to me as at least a
> temporary
> > > solution.
> >
> > I've done that locally now, thanks.
> >
> > > You probably knolw that the getTable function already allocates
> > > memory dynamically for table lists. Could this be expanded?
> >
> > Yes, that is not the problem. The sore spots are more to do with
> > constructing the completePath from tablePath and fileName in
> > compileFile for example. Or copying the tablelist into
> tablePath (in
> > compileTranslationTable). Or copying tableList into newList
> and buffer
> > (in doLang2table). It seemed quite a bit of work to get
> this going, so
> > I thought I'd take the easy route :-)
> >
> > > I'll look into it a bit also. Others who might be
> concerned should
> > > give feedback on this.
> >
> > I'd be especially interested to hear from people like
> ViewPlus or Baum
> > who (I assume) deploy liblouis on their devices. They probably
> > wouldn't like it if we'd consume more memory for no good reason.
> >
> > Thanks
> > Christian
> > --
> > Christian Egli
> > Swiss Library for the Blind, Visually Impaired and Print Disabled
> > Grubenstrasse 12, CH-8045 Z??rich, Switzerland For a description of
> > the software and to download it go to http://www.jjb-software.com
>
> --
> John J. Boyer; President, Chief Software Developer Abilitiessoft, Inc.
> http://www.abilitiessoft.com
> Madison, Wisconsin USA
> Developing software for people with disabilities
>
> For a description of the software and to download it go to
> http://www.jjb-software.com
>
>
For a description of the software and to download it go to
http://www.jjb-software.com
Other related posts:
- » [liblouis-liblouisxml] AW: Re: segfault with very long table lists - Bijewitz, Volker
