[haiku-development] Re: cgit -> XX?
- From: kallisti5 <kallisti5@xxxxxxxxxxx>
- To: haiku-development@xxxxxxxxxxxxx
- Date: Fri, 15 Sep 2017 12:29:36 -0500
On 2017-09-14 18:56, Fredrik Holmqvist wrote:
On tors 14 sep. 2017 22:58 Jérôme Duval <jerome.duval@xxxxxxxxx>
wrote:
Tools don't need to be orthogonal, Github could be a second-class
patch submission/ tool for contributors who are already registered
there.
I'm certain Gerrit or Phabricator have plugins to import or sync
Github PR as they come.
I already checked pull requests built on Travis CI (see
https://travis-ci.org/korli/haiku/builds/153183386 ;). It's also now
possible to protect branches (to forbid a merge).
+1 If we can do pull requests and hrev tags existed in Github it would
make the way I work easy. I'm not sure I have the time or interest in
a very specialised way of working. With PR's I can actually do work on
my phone in transit.. I want that.
Here are the latest votes from the horse races:
* git + trac + cgit + (GitHub PR)
* Pro: Simple, no process change.
* Con: Code review never really and option.
* Demo: cgit.haiku-os.org
* +1s: Jérôme, jessicah, Fredrik
* Github + trac (+ cgit?)
* Pro: Easy, hosted, everyone does it, pull requests a breeze.
* Con: How do we do hooks? How do we do hrev tags?
* Demo:
https://github.com
* +1s: François, Fredrik, kallisti5
* Gerrit + trac (+ cgit?)
* Pro: Has seemed popular in the past with our devs, simple to
deploy
* Con: Little "classic" looking, but it looks like they're toying
with new UI's, Java (:P)
* Demo:
https://review.openstack.org/#/q/status:open
* +1s: waddlesplash, pulkomandy, axeld, anevilyak
In the git + trac + cgit + (github PR) design, I have a few concerns how
we could handle inbound changes from two different repos (git + github).
We could merge everything, but then github and our git wouldn't be
in sync.
The only reason we're having difficulty using github + trac + cgit, is
due
to all the commit hooks we use around PM. We could work around this
if we had an HTTP server somewhere to receive the github webhooks
and "do things + accept the commit"
https://developer.github.com/webhooks/
After playing around with Gerrit... I have concerns that it is making
contributing to the project more difficult vs less.
(especially if we are going to require code review on *every* commit.
I'm strongly against that and am not giving my +1 to Gerrit due to it.)
The learning curve to commit to Haiku is already "not github simple",
why go even further down that rabbit hole? We need more contributors,
not fewer.
-- Alex
Other related posts:
