[haiku-commits] Re: r40933 - haiku/trunk/headers/os/locale
- From: "Jonas Sundström" <jonas@xxxxxxxxxxx>
- To: "haiku-commits@xxxxxxxxxxxxx" <haiku-commits@xxxxxxxxxxxxx>
- Date: Mon, 14 Mar 2011 13:17:15 +0100
Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> jonas@xxxxxxxxxxx wrote:
> > #define B_TRANSLATE_APP_NAME(string) \
> > - BLocaleRoster::Default()->GetCatalog()->GetString((string), \
> > - B_TRANSLATE_APP_NAME_CONTEXT)
> > + BLocaleRoster::Default()->IsFilesystemTranslationPreferred() \
> > + ? BLocaleRoster::Default()->GetCatalog()->GetString((string), \
> > + B_TRANSLATE_APP_NAME_CONTEXT) : (string)
>
> Since the app name should be known to the BRoster already, why not just
> add a BLocaleRoster::GetTranslatedAppName()? It wouldn't even need any
> argument AFAICT.
Right. The definition of B_TRANSLATE_APP_NAME(string) for catkey collection
still needs the string though, so it has to stay, unused in this case, I think.
/Jonas
Other related posts:
