[haiku-commits] Re: r40933 - haiku/trunk/headers/os/locale

  • From: Clemens <clemens.zeidler@xxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Mon, 14 Mar 2011 21:13:11 +1300

On Mon, 14 Mar 2011 19:23:12 +1300, Michael Pfeiffer <michael.w.pfeiffer@xxxxxxxxx> wrote: 



Am 13.03.2011 um 22:29 schrieb Axel Dörfler:


jonas@xxxxxxxxxxx wrote:

#define B_TRANSLATE_APP_NAME(string) \
-       BLocaleRoster::Default()->GetCatalog()->GetString((string), \
-               B_TRANSLATE_APP_NAME_CONTEXT)
+       BLocaleRoster::Default()->IsFilesystemTranslationPreferred() \
+       ? BLocaleRoster::Default()->GetCatalog()->GetString((string), \
+               B_TRANSLATE_APP_NAME_CONTEXT) : (string)


Since the app name should be known to the BRoster already, why not just
add a BLocaleRoster::GetTranslatedAppName()? It wouldn't even need any
argument AFAICT.



What is an app? AFAIK we are developing Haiku not iOS. ;)
Shouldn't it be called application:
B_TRANSLATE_APPLICATION_NAME_CONTEXT and GetTranslatedApplicationName
We even have a app server ;-) in principle you are right but in this case I think the shorter name is fine. 

Regards,
        Clemens

Other related posts:

  1. Home
  2. haiku-commits
  3. Archive
  4. 03-2011