[haiku-commits] Re: r40933 - haiku/trunk/headers/os/locale

  • From: "Axel Dörfler" <axeld@xxxxxxxxxxxxxxxx>
  • To: haiku-commits@xxxxxxxxxxxxx
  • Date: Tue, 15 Mar 2011 22:15:41 +0100

"Jonas Sundström" <jonas@xxxxxxxxxxx> wrote:
> Axel Dörfler <axeld@xxxxxxxxxxxxxxxx> wrote:
> > jonas@xxxxxxxxxxx wrote:
> > >  #define B_TRANSLATE_APP_NAME(string) \
> > > - BLocaleRoster::Default()->GetCatalog()->GetString((string), \
> > > -         B_TRANSLATE_APP_NAME_CONTEXT)
> > > + BLocaleRoster::Default()->IsFilesystemTranslationPreferred()
> > > \
> > > + ? BLocaleRoster::Default()->GetCatalog()->GetString((string),
> > > \
> > > +         B_TRANSLATE_APP_NAME_CONTEXT) : (string)
> > Since the app name should be known to the BRoster already, why not
> > just
> > add a BLocaleRoster::GetTranslatedAppName()? It wouldn't even need
> > any
> > argument AFAICT.
> Right. The definition of B_TRANSLATE_APP_NAME(string) for catkey
> collection
> still needs the string though, so it has to stay, unused in this
> case, I think.

If there isn't already, this could also just be another argument when
executing the catkey tool, though, but I dunno if that's really worth
the effort.

Bye,
   Axel.


Other related posts: